Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: theme mod instead of acf options for preview mode url #163

Merged
merged 5 commits into from
Oct 5, 2021

Conversation

ccorda
Copy link
Contributor

@ccorda ccorda commented Sep 28, 2021

refs #162

@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/patronage/bubs-next/ApYJoHMrpJDhLDK3hq7u9eHhvWoR
✅ Preview: https://bubs-next-git-162-preview-fixes-patronage.vercel.app

[Deployment for a6cacfa canceled]

@kylehotchkiss kylehotchkiss changed the title theme mod instead of acf options for preview mode url feat: theme mod instead of acf options for preview mode url Oct 4, 2021
# Conflicts:
#	wordpress/wp-content/themes/headless/functions.php
Copy link
Contributor Author

@ccorda ccorda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not letting me approve since I'm original author).

One thing we need to do is update the docs on setting up preview mode -- they currently refer to the theme options path, when they should refer to the appearance customize location of this PR.

@ccorda
Copy link
Contributor Author

ccorda commented Oct 4, 2021

Also as part of cleanup for this, we can remove the no longer used ACF file:
group_610de2de11430.json

@kylehotchkiss kylehotchkiss merged commit 65bf637 into main Oct 5, 2021
@kylehotchkiss kylehotchkiss deleted the 162-preview-fixes branch October 5, 2021 13:24
ccorda added a commit that referenced this pull request Dec 28, 2021
* main:
  simpler eslint config (no custom babel) (#185)
  chore: node minor dep upgrades (#188)
  docs: env variable with graphcdn
  fix bug in postheader loading wrong scss file
  fix env.sample domain for graphcdn
  fix: meta not respecting social variables, customized title (#176)
  feat: log wp admin users into front-end preview mode (#173)
  fix: Get stylelint working again (#182)
  feat: Next 12 upgrade (#180)
  feat: bumping husky to version 7 (#179)
  resolve bug where clicking 'view' in wp-admin leads to a broken redirect (#165)
  feat: new convenience plugins in wordpress admin (#166)
  feat: theme mod instead of acf options for preview mode url (#163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants