-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: simpler eslint config (no custom babel) #185
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/patronage/bubs-next/GrRMTfUc1hfSm9Y2GkZB6HBmsJhu |
* main: chore: node minor dep upgrades (#188) docs: env variable with graphcdn fix bug in postheader loading wrong scss file # Conflicts: # website/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but one thought, should we just use the eslint that the upstream Next package requires? Or does Next.js want to see Eslint loaded in our package.json in order to activate it?
I think it installs it:
|
Confirmed in a sandbox that a default next install adds the following:
|
* main: simpler eslint config (no custom babel) (#185) chore: node minor dep upgrades (#188) docs: env variable with graphcdn fix bug in postheader loading wrong scss file fix env.sample domain for graphcdn fix: meta not respecting social variables, customized title (#176) feat: log wp admin users into front-end preview mode (#173) fix: Get stylelint working again (#182) feat: Next 12 upgrade (#180) feat: bumping husky to version 7 (#179) resolve bug where clicking 'view' in wp-admin leads to a broken redirect (#165) feat: new convenience plugins in wordpress admin (#166) feat: theme mod instead of acf options for preview mode url (#163)
See parent issue for a bit more. Leaning on next configs vs. specifying our own.
closes #184