Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider cluster domain when draining capture servers across multiple kubernetes clusters #5040

Merged

Conversation

charleszheng44
Copy link
Contributor

What problem does this PR solve?

When deploying TiCDC cluster containing capture servers managed by different tidb cluster CRs across multiple Kubernetes clusters. In this case, the existing tidb operator won't be able to pick the right capture to drain, as two caputre servers may share similar advertise address prefix.

What is changed and how does it work?

Consider cluster domain when draining capture servers across multiple kubernetes clusters

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

`None`

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

@overvenus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: overvenus
Once this PR has been reviewed and has the lgtm label, please ask for approval from charleszheng44. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@charleszheng44
Copy link
Contributor Author

LGTM

@charleszheng44
Copy link
Contributor Author

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

@charleszheng44: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@charleszheng44
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2023

@charleszheng44: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 5, 2023

/run-e2e-kind-br

@charleszheng44
Copy link
Contributor Author

/run-all-e2e

@charleszheng44
Copy link
Contributor Author

/merge

@charleszheng44
Copy link
Contributor Author

/run-e2e-kind

@codecov-commenter
Copy link

Codecov Report

Merging #5040 (f7d8a5e) into master (2da77b8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5040      +/-   ##
==========================================
- Coverage   57.24%   57.24%   -0.01%     
==========================================
  Files         245      245              
  Lines       28069    28072       +3     
==========================================
+ Hits        16069    16070       +1     
- Misses      10435    10436       +1     
- Partials     1565     1566       +1     
Flag Coverage Δ
unittest 57.24% <100.00%> (-0.01%) ⬇️

@charleszheng44
Copy link
Contributor Author

/run-e2e-kind-tngm

@charleszheng44
Copy link
Contributor Author

/run-e2e-kind-br

@csuzhangxc csuzhangxc merged commit cec1c1c into pingcap:master Jun 6, 2023
@charleszheng44
Copy link
Contributor Author

/cherry-pick release-1.4

@charleszheng44
Copy link
Contributor Author

/cherry-pick release-1.5

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 6, 2023

/cherry-pick release-1.4

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 6, 2023

/cherry-pick release-1.4
/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

@wuhuizuo: The label(s) /release-1.4, /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 6, 2023

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

@wuhuizuo: The label(s) /release-1.4 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-1.4: #5042.

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request could not be created: failed to create pull request against pingcap/tidb-operator#release-1.4 from head ti-chi-bot:cherry-pick-5040-to-release-1.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-5040-to-release-1.4."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-1.5: #5043.

In response to this:

/cherry-pick release-1.4
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

charleszheng44 added a commit to pingcap/docs-tidb-operator that referenced this pull request Jun 8, 2023
@csuzhangxc csuzhangxc mentioned this pull request Jun 9, 2023
10 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-tidb-operator that referenced this pull request Jun 26, 2023
ti-chi-bot pushed a commit to ti-chi-bot/docs-tidb-operator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants