-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider cluster domain when draining capture servers across multiple kubernetes clusters #5040
Consider cluster domain when draining capture servers across multiple kubernetes clusters #5040
Conversation
… kubernetes clusters
@overvenus: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: overvenus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/test all |
@charleszheng44: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-e2e-kind |
@charleszheng44: No presubmit jobs available for pingcap/tidb-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-e2e-kind-br |
/run-all-e2e |
/merge |
/run-e2e-kind |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5040 +/- ##
==========================================
- Coverage 57.24% 57.24% -0.01%
==========================================
Files 245 245
Lines 28069 28072 +3
==========================================
+ Hits 16069 16070 +1
- Misses 10435 10436 +1
- Partials 1565 1566 +1
|
/run-e2e-kind-tngm |
/run-e2e-kind-br |
/cherry-pick release-1.4 |
/cherry-pick release-1.5 |
/cherry-pick release-1.4 |
/cherry-pick release-1.4 |
@wuhuizuo: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-1.4 |
@wuhuizuo: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wuhuizuo: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wuhuizuo: new pull request could not be created: failed to create pull request against pingcap/tidb-operator#release-1.4 from head ti-chi-bot:cherry-pick-5040-to-release-1.4: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-5040-to-release-1.4."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wuhuizuo: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
add release note for feature pingcap/tidb-operator#5040
add release note for feature pingcap/tidb-operator#5040
add release note for feature pingcap/tidb-operator#5040
What problem does this PR solve?
When deploying TiCDC cluster containing capture servers managed by different tidb cluster CRs across multiple Kubernetes clusters. In this case, the existing tidb operator won't be able to pick the right capture to drain, as two caputre servers may share similar advertise address prefix.
What is changed and how does it work?
Consider cluster domain when draining capture servers across multiple kubernetes clusters
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.