Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TiCDC across K8s address (#5060) #5061

Merged
merged 1 commit into from
Jun 10, 2023
Merged

fix TiCDC across K8s address (#5060) #5061

merged 1 commit into from
Jun 10, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5060

What problem does this PR solve?

fix bug introduced in #5040

W0609 09:40:30.451678       1 ticdc_member_manager.go:268] Failed to get status for Pod tc-1-ticdc-0 of [ns-1/tc-1], error: Get "http://tc-1-ticdc-0.tc-1-ticdc-peer.ns-1.cluster.local:8301/status": dial tcp: lookup tc-1-ticdc-0.tc-1-ticdc-peer.ns-1.cluster.local on 10.234.0.10:53: no such host

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 10, 2023
Merged
10 tasks
@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 June 10, 2023 01:13
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu June 10, 2023 01:13
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023 •
edited
Loading

Codecov Report

Merging #5061 (348b8e0) into release-1.4 (71d8502) will increase coverage by 8.80%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.4    #5061      +/-   ##
===============================================
+ Coverage        58.85%   67.65%   +8.80%     
===============================================
  Files              227      231       +4     
  Lines            26268    29422    +3154     
===============================================
+ Hits             15459    19905    +4446     
+ Misses            9325     7991    -1334     
- Partials          1484     1526      +42
Flag Coverage Δ
e2e 52.49% <100.00%> (?)
unittest 58.84% <100.00%> (-0.01%) ⬇️

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-basic
/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-basic, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-basic
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-br
/test pull-e2e-kind-seria

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-br, /pull-e2e-kind-seria cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br
/test pull-e2e-kind-seria

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-br
/test pull-e2e-kind-seria

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously
/test pull-e2e-kind-tngm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-serial, /pull-e2e-kind-tikv-scale-simultaneously, /pull-e2e-kind-tngm cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-tikv-scale-simultaneously

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 10, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc csuzhangxc merged commit 6bc596a into pingcap:release-1.4 Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardlau1999 howardlau1999 Awaiting requested review from howardlau1999

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees

@csuzhangxc csuzhangxc

Labels
size/XS type/cherry-pick-for-release-1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @codecov-commenter @csuzhangxc