Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TiCDC across K8s address #5060

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

fix bug introduced in #5040

W0609 09:40:30.451678       1 ticdc_member_manager.go:268] Failed to get status for Pod tc-1-ticdc-0 of [ns-1/tc-1], error: Get "http://tc-1-ticdc-0.tc-1-ticdc-peer.ns-1.cluster.local:8301/status": dial tcp: lookup tc-1-ticdc-0.tc-1-ticdc-peer.ns-1.cluster.local on 10.234.0.10:53: no such host

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested review from KanShiori and shonge June 9, 2023 09:49
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS label Jun 9, 2023
@csuzhangxc
Copy link
Member Author

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.4 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@csuzhangxc: The label(s) /release-1.4 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@csuzhangxc: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc csuzhangxc mentioned this pull request Jun 8, 2023
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Merging #5060 (3a789ca) into master (0cd7c85) will increase coverage by 1.31%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5060      +/-   ##
==========================================
+ Coverage   57.25%   58.56%   +1.31%     
==========================================
  Files         245      249       +4     
  Lines       28073    31423    +3350     
==========================================
+ Hits        16073    18403    +2330     
- Misses      10435    11398     +963     
- Partials     1565     1622      +57     
Flag Coverage Δ
e2e 26.48% <100.00%> (?)
unittest 57.26% <100.00%> (+0.01%) ⬆️

@csuzhangxc
Copy link
Member Author

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@csuzhangxc: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc csuzhangxc merged commit 87e3985 into pingcap:master Jun 10, 2023
@csuzhangxc csuzhangxc deleted the fix-cdc-x-k8s branch June 10, 2023 01:12
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.4: #5061.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5062.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants