Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several cases of copyright infringement #45

Closed
cznic opened this issue Sep 7, 2015 · 4 comments · Fixed by #46
Closed

Several cases of copyright infringement #45

cznic opened this issue Sep 7, 2015 · 4 comments · Fixed by #46

Comments

@cznic
Copy link

cznic commented Sep 7, 2015

This repository publishes code copied from and/or based on copyrighted 3rd party code published under specific licenses; without fulfilling the terms defined in those licenses. Particularly, the original license comments in the original files were removed and replaced by a license claim of the infringing party. That's not acceptable. Also, it's just silly, as the original licenses permit to use/modify/republish or even sell the code without having to pay anything to the authors of the original code.

Examples

  • format.go contains verbatim copies of parts of code originaly published in strutil.go.
  • btree.go contains verbatim copies of parts of code originaly published in btree.go.
  • Many files found in the plan directory contain code clearly derived and/or parts sometimes verbatim copied from code originally published in plan.go.

In only minutes, I was able to found tens of similar additional copyright infringements. Also, this repository now has 100+ of forks and every single fork has the same copyright issue.

In essence, this project is an adaption/extension of the QL project for other SQL syntax and features, including alternative back-ends. (Which is, in sum, an amazing achievement - sincere congratulations.)

To the owners, maintainers of this repository: Please let me know your thoughts/plans/intentions related to this issue. Thanks.

@c4pt0r
Copy link
Member

c4pt0r commented Sep 7, 2015

Thank you for your comment! TiDB is derived from the cznic/ql codebase, thank you again for the awesome job!

We'll add the ql-licence declaration in the files that contains your code. Is that OK? Please let us know :)
Just like this:

// Copyright 2015 The ql Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

// Copyright 2015 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

.....
@cznic

@cznic
Copy link
Author

cznic commented Sep 8, 2015

@c4pt0r Thank you for the feedback, SGTM.

@c4pt0r c4pt0r reopened this Sep 8, 2015
@c4pt0r
Copy link
Member

c4pt0r commented Sep 9, 2015

Fixed.
#74

@c4pt0r c4pt0r closed this as completed Sep 9, 2015
@astaxie
Copy link
Contributor

astaxie commented Sep 9, 2015

👍

YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
A simple document about the modification(in Chinese):
https://docs.google.com/document/d/1arRYZj7_wOEb1up-PVBhVPc457JznJfSQzq7bItQqmM/edit

The objective of the PR is going to promote the stability while loading data to tikv server. Some tests result also recorded in the above document.

Something about the code:

importpb/* has been deleted because now we import pb code from vendor.
A little bit metrics were added for test and more metrics will be added in the following PR(not done)
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
xhebox pushed a commit to xhebox/tidb that referenced this issue Sep 28, 2021
Change TiDB to use same default as MySQL 5.7
xhebox pushed a commit to xhebox/tidb that referenced this issue Oct 8, 2021
Change TiDB to use same default as MySQL 5.7
ti-chi-bot pushed a commit that referenced this issue Oct 9, 2021
Change TiDB to use same default as MySQL 5.7
okJiang pushed a commit to okJiang/tidb that referenced this issue Oct 19, 2021
* addMetaData output for dumpling

* fix bug

* change instance to pointer

* fix
Defined2014 pushed a commit to Defined2014/tidb that referenced this issue Apr 11, 2022
iosmanthus pushed a commit to iosmanthus/tidb that referenced this issue Oct 31, 2022
rleungx pushed a commit to rleungx/tidb that referenced this issue Feb 26, 2024
* init

* audit: init first version of audit log

* audit: support log global rotate

* audit: update log keys

* audit: more common notify implement

* audit: add record id

* audit: rename some names

* audit: default use normal log path

* audit: add server ip info

* audit: do some refine

* audit: Add some log keys

* audit: update some item format

* audit: add stmt demo

* audit: support redact

* audit: fix bug

* audit: update filter

* audit: update filter

* audit: check user

* audit: update

* update

* audit: update

* audit: fix bug

* aduit: update

* audit: update

* update

* update

* audit: add filter unit test

* fmt

* Add tests for `tidb_audit_enabled` and `tidb_audit_log`

* Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime`

* Add tests for `tidb_audit_log_reserved_*`

* TODO: TestAuditLogRedact

* Fininsh `TestAuditLogRedact`

* Update (pingcap#1)

* fix typo (pingcap#2)

* Add `TRANSACTION`

* rename sysvar

* audit_log_create_filter, audit_log_remove_filter

* finish function call and table test

* test privilege

* finish test for sysvar

* TODO: TestConnectionEvenClass

* update

* audit: fix lint for audit log (pingcap#1)

* audit: fix UT failure caused by the change of redact log (pingcap#3)

* audit: use `t.TempDir()` to make test stable (pingcap#4)

* audit: fix test failed for 7.1

* Add `OWNERS` file (pingcap#35)

Co-authored-by: Chao Wang <[email protected]>

* audit: fix panic when logging sometime (pingcap#26) (pingcap#31)

* test: fix unstable test TestAuditLogReservedDays (pingcap#8)

* Format sysvar_test.go

* audit: use `StatementContext` to generate redacted SQL (pingcap#9)

* audit: fix panic when logging sometime (pingcap#26)

* update

* add owner

* Update OWNERS

---------

Co-authored-by: CbcWestwolf <[email protected]>
Co-authored-by: wuhuizuo <[email protected]>

* audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39)

* This is an automated cherry-pick of pingcap#37

Signed-off-by: ti-chi-bot <[email protected]>

* fix conflict

---------

Signed-off-by: ti-chi-bot <[email protected]>
Co-authored-by: 王超 <[email protected]>

* extension/audit: introduce serverless audit log

Signed-off-by: Wen Jiazhi <[email protected]>

* update bazel config

Signed-off-by: Wen Jiazhi <[email protected]>

* support enable audit log when activate

Signed-off-by: Wen Jiazhi <[email protected]>

* add gwconnid to audit log

Signed-off-by: Wen Jiazhi <[email protected]>

* comment unstable test

* update bazel

* add log about activate request

* diff audit log enabled

* audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45)

* This is an automated cherry-pick of pingcap#44

Signed-off-by: ti-chi-bot <[email protected]>

* Update util.go

---------

Signed-off-by: ti-chi-bot <[email protected]>
Co-authored-by: 王超 <[email protected]>

* Update extension/serverless/OWNERS

---------

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Wen Jiazhi <[email protected]>
Co-authored-by: Chao Wang <[email protected]>
Co-authored-by: cbcwestwolf <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Co-authored-by: wuhuizuo <[email protected]>
Co-authored-by: zzm <[email protected]>
Co-authored-by: Yuqing Bai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants