Improve Documentation: various corrections of the English usage i… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! |
|
LGTM |
1 similar comment
|
LGTM |
ngaut
added a commit
that referenced
this pull request
Sep 6, 2015
…usage Improvement Documentation: various corrections of the English usage i…
chuchao333
changed the title
coocood
added a commit
to coocood/tidb
that referenced
this pull request
Apr 18, 2019
IggieWang
referenced
this pull request
in IggieWang/tidb
Aug 11, 2019
finish virtual index DDL statement
windtalker
added a commit
to windtalker/tidb
that referenced
this pull request
Apr 22, 2020
basic cbo support for broadcast join
Deardrops
pushed a commit
to Deardrops/tidb
that referenced
this pull request
May 15, 2020
privilege: support login fail count and account blacklist
abbccdda
pushed a commit
to abbccdda/tidb
that referenced
this pull request
Jan 16, 2021
store: make network cost threshold as a Variable
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* package for hanlding key-value operations * with error checks * kv encode now support execute sql convert in 'prepare statement' mode * address comment * address comment
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
backup: support rate limit
knull-cn
added a commit
to knull-cn/tidb
that referenced
this pull request
Dec 31, 2021
add rfc for hackathon 2021
TszKitLo40
pushed a commit
to TszKitLo40/tidb
that referenced
this pull request
Jan 3, 2022
crazycs520
referenced
this pull request
in crazycs520/tidb
Jan 6, 2022
create `aws` SQL, support WHERE for TableScan and Selection
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Mar 2, 2022
12 tasks
sleepymole
referenced
this pull request
in sleepymole/tidb
Aug 22, 2022
Fine tuning dry-run in order to avoid recover-data
zhongzc
pushed a commit
to zhongzc/tidb
that referenced
this pull request
Feb 2, 2023
keeplearning20221
added a commit
to keeplearning20221/tidb
that referenced
this pull request
Feb 13, 2023
…ules/golang.org/x/oauth2-0.5.0 build(deps): bump golang.org/x/oauth2 from 0.2.0 to 0.5.0
ljun0712
pushed a commit
to ljun0712/tidb
that referenced
this pull request
Mar 1, 2023
rebelice
added a commit
to rebelice/tidb
that referenced
this pull request
Mar 28, 2023
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
* init * audit: init first version of audit log * audit: support log global rotate * audit: update log keys * audit: more common notify implement * audit: add record id * audit: rename some names * audit: default use normal log path * audit: add server ip info * audit: do some refine * audit: Add some log keys * audit: update some item format * audit: add stmt demo * audit: support redact * audit: fix bug * audit: update filter * audit: update filter * audit: check user * audit: update * update * audit: update * audit: fix bug * aduit: update * audit: update * update * update * audit: add filter unit test * fmt * Add tests for `tidb_audit_enabled` and `tidb_audit_log` * Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime` * Add tests for `tidb_audit_log_reserved_*` * TODO: TestAuditLogRedact * Fininsh `TestAuditLogRedact` * Update (pingcap#1) * fix typo (pingcap#2) * Add `TRANSACTION` * rename sysvar * audit_log_create_filter, audit_log_remove_filter * finish function call and table test * test privilege * finish test for sysvar * TODO: TestConnectionEvenClass * update * audit: fix lint for audit log (pingcap#1) * audit: fix UT failure caused by the change of redact log (pingcap#3) * audit: use `t.TempDir()` to make test stable (pingcap#4) * audit: fix test failed for 7.1 * Add `OWNERS` file (pingcap#35) Co-authored-by: Chao Wang <[email protected]> * audit: fix panic when logging sometime (pingcap#26) (pingcap#31) * test: fix unstable test TestAuditLogReservedDays (pingcap#8) * Format sysvar_test.go * audit: use `StatementContext` to generate redacted SQL (pingcap#9) * audit: fix panic when logging sometime (pingcap#26) * update * add owner * Update OWNERS --------- Co-authored-by: CbcWestwolf <[email protected]> Co-authored-by: wuhuizuo <[email protected]> * audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39) * This is an automated cherry-pick of pingcap#37 Signed-off-by: ti-chi-bot <[email protected]> * fix conflict --------- Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: 王超 <[email protected]> * extension/audit: introduce serverless audit log Signed-off-by: Wen Jiazhi <[email protected]> * update bazel config Signed-off-by: Wen Jiazhi <[email protected]> * support enable audit log when activate Signed-off-by: Wen Jiazhi <[email protected]> * add gwconnid to audit log Signed-off-by: Wen Jiazhi <[email protected]> * comment unstable test * update bazel * add log about activate request * diff audit log enabled * audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45) * This is an automated cherry-pick of pingcap#44 Signed-off-by: ti-chi-bot <[email protected]> * Update util.go --------- Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: 王超 <[email protected]> * Update extension/serverless/OWNERS --------- Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: Wen Jiazhi <[email protected]> Co-authored-by: Chao Wang <[email protected]> Co-authored-by: cbcwestwolf <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]> Co-authored-by: wuhuizuo <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: Yuqing Bai <[email protected]>
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…oschema cache size and refine metric (pingcap#46684) (pingcap#4) Signed-off-by: crazycs520 <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: crazycs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sharing the great work! Just try to improve the README as I am reading through it.