Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix resuming to wrong checkpoint when failed during adding index #55506

Merged
merged 1 commit into from
Aug 20, 2024
Merged

ddl: fix resuming to wrong checkpoint when failed during adding index #55506

merged 1 commit into from
Aug 20, 2024

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #55488

Problem Summary:

See #55488 (comment).

The end key in checkpoint should be "next unprocessed key" instead of "last processed key".

What changed and how does it work?

  • Remove .Next() for checkpoint end key when resuming.
  • Add an integration test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2024
@tiprow tiprow
Copy link

tiprow bot commented Aug 19, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.9393%. Comparing base (f751f73) to head (ea44593).
Report is 19 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #55506        +/-   ##
================================================
+ Coverage   72.9184%   75.9393%   +3.0208%     
================================================
  Files          1576       1576                
  Lines        440806     443890      +3084     
================================================
+ Hits         321429     337087     +15658     
+ Misses        99636      86253     -13383     
- Partials      19741      20550       +809
Flag Coverage Δ
integration 50.9982% <100.0000%> (?)
unit 72.0455% <33.3333%> (+0.0512%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 64.5431% <ø> (+18.5492%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 20, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-20 02:13:34.239477625 +0000 UTC m=+231609.373927745: ☑️ agreed by wjhuang2016.
  • 2024-08-20 05:50:02.699623895 +0000 UTC m=+244597.834074015: ☑️ agreed by lance6716.

Benjamin2037
Benjamin2037 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 6d95459 into pingcap:master Aug 20, 2024
24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #55532.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 20, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 20, 2024
@ti-chi-bot
ddl: fix resuming to wrong checkpoint when failed during adding index (…
1a0c3ac 
…#55506) (#55532)

close #55488
breezewish added a commit that referenced this pull request Aug 21, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/vector-merg…
80d9f5f 
…e-upstream

* origin/master:
  parser:  call `SetText` correctly for `CreateViewStmt` (#55520)
  lighting: expose limited fields for `kv.Session` (#55517)
  show: prefilter table name with like pattern and show full tables (#55396)
  Planner: Do not allow cardinality to go below 1 (#55242)
  *: replace maps.Copy which is for map clone with std maps.Clone (#55530)
  infoschema: add WithRefillOption for TableByName and TableByID (#55511)
  domain: change groupSize in splitForConcurrentFetch (#55518)
  ddl: fix resuming to wrong checkpoint when failed during adding index (#55506)
breezewish added a commit to breezewish/tidb that referenced this pull request Aug 21, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/vector-merg…
e0fd46a 
…e-upstream

* origin/master:
  parser:  call `SetText` correctly for `CreateViewStmt` (pingcap#55520)
  lighting: expose limited fields for `kv.Session` (pingcap#55517)
  show: prefilter table name with like pattern and show full tables (pingcap#55396)
  Planner: Do not allow cardinality to go below 1 (pingcap#55242)
  *: replace maps.Copy which is for map clone with std maps.Clone (pingcap#55530)
  infoschema: add WithRefillOption for TableByName and TableByID (pingcap#55511)
  domain: change groupSize in splitForConcurrentFetch (pingcap#55518)
  ddl: fix resuming to wrong checkpoint when failed during adding index (pingcap#55506)

Signed-off-by: Wish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.3 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@tangenta @ti-chi-bot @lance6716 @Benjamin2037 @wjhuang2016