domain: change groupSize in splitForConcurrentFetch #55518
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @joechenrh. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg/domain/domain.go
Outdated
| groupSize := (schemaCnt + groupCnt - 1) / groupCnt | ||
| splitted := make([][]*model.DBInfo, 0, groupCnt) | ||
|
|
||
| for start := 0; start < schemaCnt; start += groupSize { |
There was a problem hiding this comment.
suppose schemaCnt=9, groupCnt=8, groupSize will be 2, splitted will be 2/2/2/2/1
use mathutil.Divide2Batches
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55518 +/- ##
================================================
+ Coverage 72.8684% 75.6441% +2.7756%
================================================
Files 1576 1576
Lines 440786 441311 +525
================================================
+ Hits 321194 333826 +12632
+ Misses 99839 86956 -12883
- Partials 19753 20529 +776
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/test pull-br-integration-test |
|
@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
…e-upstream * origin/master: parser: call `SetText` correctly for `CreateViewStmt` (#55520) lighting: expose limited fields for `kv.Session` (#55517) show: prefilter table name with like pattern and show full tables (#55396) Planner: Do not allow cardinality to go below 1 (#55242) *: replace maps.Copy which is for map clone with std maps.Clone (#55530) infoschema: add WithRefillOption for TableByName and TableByID (#55511) domain: change groupSize in splitForConcurrentFetch (#55518) ddl: fix resuming to wrong checkpoint when failed during adding index (#55506)
…e-upstream * origin/master: parser: call `SetText` correctly for `CreateViewStmt` (pingcap#55520) lighting: expose limited fields for `kv.Session` (pingcap#55517) show: prefilter table name with like pattern and show full tables (pingcap#55396) Planner: Do not allow cardinality to go below 1 (pingcap#55242) *: replace maps.Copy which is for map clone with std maps.Clone (pingcap#55530) infoschema: add WithRefillOption for TableByName and TableByID (pingcap#55511) domain: change groupSize in splitForConcurrentFetch (pingcap#55518) ddl: fix resuming to wrong checkpoint when failed during adding index (pingcap#55506) Signed-off-by: Wish <[email protected]>
What problem does this PR solve?
Issue Number: ref #50959
Problem Summary:
What changed and how does it work?
Change splitted group count to 8 instead of group size when using infoschema V2.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.