Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: call SetText correctly for CreateViewStmt #55520

Merged
merged 1 commit into from
Aug 21, 2024
Merged

parser: call SetText correctly for CreateViewStmt #55520

merged 1 commit into from
Aug 21, 2024

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #55441

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 20, 2024
@tiprow tiprow
Copy link

tiprow bot commented Aug 20, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 changed the title parser: SetText correctly for CreateViewStmt parser: call SetText correctly for CreateViewStmt Aug 20, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1615%. Comparing base (8f75ed3) to head (9c4661a).
Report is 19 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #55520        +/-   ##
================================================
+ Coverage   72.9033%   75.1615%   +2.2581%     
================================================
  Files          1576       1576                
  Lines        440819     444504      +3685     
================================================
+ Hits         321372     334096     +12724     
+ Misses        99705      90191      -9514     
- Partials      19742      20217       +475
Flag Coverage Δ
integration 49.6621% <66.6666%> (?)
unit 74.4808% <100.0000%> (+2.5101%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 53.3657% <ø> (+7.4259%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 20, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-20 06:59:34.843582525 +0000 UTC m=+248769.978032646: ☑️ agreed by xhebox.
  • 2024-08-20 07:12:20.090858589 +0000 UTC m=+249535.225308712: ☑️ agreed by tangenta.

@easonn7
Copy link

easonn7 commented Aug 21, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, tangenta, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3464dae into pingcap:master Aug 21, 2024
23 checks passed
breezewish added a commit that referenced this pull request Aug 21, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/vector-merg…
80d9f5f 
…e-upstream

* origin/master:
  parser:  call `SetText` correctly for `CreateViewStmt` (#55520)
  lighting: expose limited fields for `kv.Session` (#55517)
  show: prefilter table name with like pattern and show full tables (#55396)
  Planner: Do not allow cardinality to go below 1 (#55242)
  *: replace maps.Copy which is for map clone with std maps.Clone (#55530)
  infoschema: add WithRefillOption for TableByName and TableByID (#55511)
  domain: change groupSize in splitForConcurrentFetch (#55518)
  ddl: fix resuming to wrong checkpoint when failed during adding index (#55506)
breezewish added a commit to breezewish/tidb that referenced this pull request Aug 21, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/vector-merg…
e0fd46a 
…e-upstream

* origin/master:
  parser:  call `SetText` correctly for `CreateViewStmt` (pingcap#55520)
  lighting: expose limited fields for `kv.Session` (pingcap#55517)
  show: prefilter table name with like pattern and show full tables (pingcap#55396)
  Planner: Do not allow cardinality to go below 1 (pingcap#55242)
  *: replace maps.Copy which is for map clone with std maps.Clone (pingcap#55530)
  infoschema: add WithRefillOption for TableByName and TableByID (pingcap#55511)
  domain: change groupSize in splitForConcurrentFetch (pingcap#55518)
  ddl: fix resuming to wrong checkpoint when failed during adding index (pingcap#55506)

Signed-off-by: Wish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@tangenta tangenta tangenta approved these changes

@YangKeao YangKeao Awaiting requested review from YangKeao

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can I get the original text of a parser node?
4 participants
@Defined2014 @easonn7 @xhebox @tangenta