Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaking test: TestIteratorWithTableFilter #5798

Closed
Tracked by #2246
Rustin170506 opened this issue Jun 8, 2022 · 4 comments · Fixed by #6116
Closed
Tracked by #2246

Flaking test: TestIteratorWithTableFilter #5798

Rustin170506 opened this issue Jun 8, 2022 · 4 comments · Fixed by #6116
Assignees
@Rustin170506
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. severity/minor type/bug The issue is confirmed as a bug.

Comments

@Rustin170506
Copy link
Member

Which jobs are flaking?

leak-test

Which test(s) are flaking?

TestIteratorWithTableFilter

Jenkins logs or GitHub Actions link

[2022-06-08T09:50:30.637Z] ok  	github.com/pingcap/tiflow/pkg/cyclic	0.218s

[2022-06-08T09:50:30.637Z] ok  	github.com/pingcap/tiflow/pkg/cyclic/mark	0.101s

[2022-06-08T09:50:30.637Z] --- FAIL: TestIteratorWithTableFilter (0.04s)

[2022-06-08T09:50:30.637Z]     pebble_test.go:80: 

[2022-06-08T09:50:30.637Z]         	Error Trace:	pebble_test.go:80

[2022-06-08T09:50:30.637Z]         	Error:      	Not equal: 

[2022-06-08T09:50:30.637Z]         	            	expected: 9

[2022-06-08T09:50:30.637Z]         	            	actual  : 16

https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_leak_test/detail/cdc_ghpr_leak_test/28036/pipeline

Anything else we need to know

  • Does this test exist for other branches as well?

  • Has there been a high frequency of failure lately?
@Rustin170506 Rustin170506 added the component/test Unit tests and integration tests component. label Jun 8, 2022
@Rustin170506 Rustin170506 mentioned this issue Jun 8, 2022
Closed
@3AceShowHand 3AceShowHand added the area/ticdc Issues or PRs related to TiCDC. label Jun 10, 2022
@Rustin170506
Copy link
Member Author

I have tested it locally thousands of times without reproducing it. So close it for now and if you find this problem again please reopen it.

@zhaoxinyu
Copy link
Contributor

another case:
https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_test/detail/cdc_ghpr_test/16948/pipeline

@Rustin170506 Rustin170506 reopened this Jun 19, 2022
@asddongmen
Copy link
Contributor 


[2022-06-20T10:24:48.052Z] === Failed

[2022-06-20T10:24:48.052Z] === FAIL: pkg/db TestIteratorWithTableFilter (0.03s)

[2022-06-20T10:24:48.052Z]     pebble_test.go:80: 

[2022-06-20T10:24:48.052Z]         	Error Trace:	pebble_test.go:80

[2022-06-20T10:24:48.052Z]         	Error:      	Not equal: 

[2022-06-20T10:24:48.052Z]         	            	expected: 9

[2022-06-20T10:24:48.052Z]         	            	actual  : 16

[2022-06-20T10:24:48.052Z]         	Test:       	TestIteratorWithTableFilter

[2022-06-20T10:24:48.052Z] 

[2022-06-20T10:24:48.052Z] DONE 2495 tests, 1 failure in 570.556s

[2022-06-20T10:24:51.336Z] make: *** [unit_test_in_verify_ci] Error 1

https://ci.pingcap.net/blue/organizations/jenkins/ut-check/detail/ut-check/18241/pipeline/

Another one.

@CharlesCheung96
Copy link
Contributor

another case:

[2022-06-22T03:10:25.963Z] --- FAIL: TestIteratorWithTableFilter (1.14s)

[2022-06-22T03:10:25.963Z]     pebble_test.go:80: 

[2022-06-22T03:10:25.963Z]         	Error Trace:	pebble_test.go:80

[2022-06-22T03:10:25.963Z]         	Error:      	Not equal: 

[2022-06-22T03:10:25.963Z]         	            	expected: 7

[2022-06-22T03:10:25.963Z]         	            	actual  : 16

[2022-06-22T03:10:25.963Z]         	Test:       	TestIteratorWithTableFilter

[2022-06-22T03:10:25.963Z] FAIL

[2022-06-22T03:10:25.963Z] FAIL	github.com/pingcap/tiflow/pkg/db	1.525s

https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_leak_test/detail/cdc_ghpr_leak_test/29120/pipeline

@Rustin170506 Rustin170506 mentioned this issue Jun 27, 2022
Closed
@Rustin170506 Rustin170506 added severity/minor type/bug The issue is confirmed as a bug. labels Jun 27, 2022
@hicqu hicqu mentioned this issue Jun 29, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jun 30, 2022
@hicqu
cdc: upgrade pebble and stabilize a case (#6116)
c9562c0 
close #5798
asddongmen pushed a commit that referenced this issue Jul 1, 2022
@buchuitoudegou @hicqu
@overvenus @sleepymole
Merge branch 'master' into cli-use-open-api and resolve conflicts (#6137
1f8d40c 
)

* syncer(dm): init schemaTracker when syncer run (#6052)

close #6014

* cdc: upgrade pebble and stabilize a case (#6116)

close #5798

* meta(engine): Resourcemeta support job level isolation (#5817)

close #5816

* owner(cdc): clean up admin jobs on async close (#6129)

close #6128

* pkg/errctx(engine): avoid creating goroutinue in errctx (#6061)

ref #6013

* cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds (#6097)

* cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds
* cdc: correct drain capture doc

Signed-off-by: Neil Shen <[email protected]>

* cdc: drain waits for owner resign and table move out

Signed-off-by: Neil Shen <[email protected]>

* tp(cdc): make drain capture scheduler aware of capture state

Signed-off-by: Neil Shen <[email protected]>

* cdc: remove verbose log and set liveness stop after resign owner

Signed-off-by: Neil Shen <[email protected]>

* cdc: skip owner resign when there is only one capture

Signed-off-by: Neil Shen <[email protected]>

* fix ut

* apply comments

* fix integration test

* fix lint

Co-authored-by: Obliviate <[email protected]>
Co-authored-by: qupeng <[email protected]>
Co-authored-by: maxshuang <[email protected]>
Co-authored-by: Neil Shen <[email protected]>
Co-authored-by: Yujie Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rustin170506 Rustin170506

Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc: upgrade pebble and stabilize a case hicqu/ticdc
5 participants
@zhaoxinyu @3AceShowHand @asddongmen @Rustin170506 @CharlesCheung96