pkg/errctx(engine): avoid creating goroutinue in errctx #6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
release-note-none
ti-chi-bot
added
the
size/L
liuzix
reviewed
Jun 28, 2022
amyangfei
reviewed
Jun 28, 2022
ti-chi-bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
e2e tests failed. Because some structures may store the |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6061 +/- ##
================================================
- Coverage 58.6479% 57.8175% -0.8305%
================================================
Files 711 702 -9
Lines 83933 82942 -991
================================================
- Hits 49225 47955 -1270
- Misses 30258 30632 +374
+ Partials 4450 4355 -95 |
|
@liuzix @amyangfei @maxshuang e2e test passed. PTAL thanks. |
amyangfei
approved these changes
Jun 30, 2022
maxshuang
approved these changes
Jun 30, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 1d564d7
|
ti-chi-bot
added
the
status/can-merge
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
status/can-merge
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 176bfff
|
ti-chi-bot
added
the
status/can-merge
|
/run-verify |
asddongmen
pushed a commit
that referenced
this pull request
Jul 1, 2022
) * syncer(dm): init schemaTracker when syncer run (#6052) close #6014 * cdc: upgrade pebble and stabilize a case (#6116) close #5798 * meta(engine): Resourcemeta support job level isolation (#5817) close #5816 * owner(cdc): clean up admin jobs on async close (#6129) close #6128 * pkg/errctx(engine): avoid creating goroutinue in errctx (#6061) ref #6013 * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds (#6097) * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds * cdc: correct drain capture doc Signed-off-by: Neil Shen <[email protected]> * cdc: drain waits for owner resign and table move out Signed-off-by: Neil Shen <[email protected]> * tp(cdc): make drain capture scheduler aware of capture state Signed-off-by: Neil Shen <[email protected]> * cdc: remove verbose log and set liveness stop after resign owner Signed-off-by: Neil Shen <[email protected]> * cdc: skip owner resign when there is only one capture Signed-off-by: Neil Shen <[email protected]> * fix ut * apply comments * fix integration test * fix lint Co-authored-by: Obliviate <[email protected]> Co-authored-by: qupeng <[email protected]> Co-authored-by: maxshuang <[email protected]> Co-authored-by: Neil Shen <[email protected]> Co-authored-by: Yujie Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6013.
What is changed and how it works?
Avoid creating goroutinue in errctx.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note