Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owner jobs may leak when resign owner #6128

Closed
overvenus opened this issue Jun 30, 2022 · 0 comments · Fixed by #6129
Closed

Owner jobs may leak when resign owner #6128

overvenus opened this issue Jun 30, 2022 · 0 comments · Fixed by #6129
Labels
area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

What did you do?

Resign owner while send owner jobs.

What did you expect to see?

All owner jobs get completed.

What did you see instead?

Caller may block on job.done channel.

Versions of the cluster

TiCDC version (execute cdc version):

master
@overvenus overvenus added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. severity/minor labels Jun 30, 2022
asddongmen pushed a commit that referenced this issue Jul 1, 2022
)

* syncer(dm): init schemaTracker when syncer run (#6052)

close #6014

* cdc: upgrade pebble and stabilize a case (#6116)

close #5798

* meta(engine): Resourcemeta support job level isolation (#5817)

close #5816

* owner(cdc): clean up admin jobs on async close (#6129)

close #6128

* pkg/errctx(engine): avoid creating goroutinue in errctx (#6061)

ref #6013

* cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds (#6097)

* cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds
* cdc: correct drain capture doc

Signed-off-by: Neil Shen <[email protected]>

* cdc: drain waits for owner resign and table move out

Signed-off-by: Neil Shen <[email protected]>

* tp(cdc): make drain capture scheduler aware of capture state

Signed-off-by: Neil Shen <[email protected]>

* cdc: remove verbose log and set liveness stop after resign owner

Signed-off-by: Neil Shen <[email protected]>

* cdc: skip owner resign when there is only one capture

Signed-off-by: Neil Shen <[email protected]>

* fix ut

* apply comments

* fix integration test

* fix lint

Co-authored-by: Obliviate <[email protected]>
Co-authored-by: qupeng <[email protected]>
Co-authored-by: maxshuang <[email protected]>
Co-authored-by: Neil Shen <[email protected]>
Co-authored-by: Yujie Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant