POC Piped v1 planner with plugin deployment interface #5074

khanhtc1202 · 2024-07-25T11:50:41Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4980

Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <[email protected]>

Signed-off-by: Yoshiki Fujikane <[email protected]>

Signed-off-by: khanhtc1202 <[email protected]>

* Register otel TracerProvider to send traces Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Bump gRPC version Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Upgrade google.golang.org/grpc Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

Signed-off-by: t-kikuc <[email protected]>

Signed-off-by: khanhtc1202 <[email protected]>

codecov · 2024-07-29T09:29:11Z

Codecov Report

Attention: Patch coverage is 4.35897% with 373 lines in your changes missing coverage. Please review.

Project coverage is 22.67%. Comparing base (b9ffb09) to head (8b0c246).
Report is 24 commits behind head on master.

Files	Patch %	Lines
pkg/app/pipedv1/controller/planner.go	5.34%	299 Missing and 2 partials ⚠️
pkg/app/piped/cmd/piped/piped.go	0.00%	48 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go	0.00%	16 Missing ⚠️
pkg/app/piped/executor/ecs/ecs.go	0.00%	3 Missing ⚠️
pkg/app/piped/executor/lambda/lambda.go	0.00%	1 Missing ⚠️
pkg/app/piped/platformprovider/cloudrun/cache.go	0.00%	1 Missing ⚠️
pkg/app/piped/platformprovider/kubernetes/cache.go	0.00%	1 Missing ⚠️
pkg/app/pipedv1/controller/controller.go	0.00%	1 Missing ⚠️
pkg/app/pipedv1/deploysource/deploysource.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5074      +/-   ##
==========================================
- Coverage   22.80%   22.67%   -0.13%     
==========================================
  Files         410      409       -1     
  Lines       43382    43660     +278     
==========================================
+ Hits         9895     9902       +7     
- Misses      32709    32977     +268     
- Partials      778      781       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: khanhtc1202 <[email protected]>

* fix typo: aplication -> application Signed-off-by: t-kikuc <[email protected]> * fix typo: put from -> put into Signed-off-by: t-kikuc <[email protected]> * fix typo: to rolling out -> to roll out Signed-off-by: t-kikuc <[email protected]> * fix: 'service manifest' -> 'lambda function manifest' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>

* fix available values of SharedSSOConfig.provider Signed-off-by: t-kikuc <[email protected]> * fix description of supported SSO services. Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>

* Rename file referring to other platforms Signed-off-by: t-kikuc <[email protected]> * Add ECS to live-state protobuf Signed-off-by: t-kikuc <[email protected]> * Impl ECS APIs Signed-off-by: t-kikuc <[email protected]> * Impl ECS's state.go Signed-off-by: t-kikuc <[email protected]> * Fix the healthDescription because a task has two statuses Signed-off-by: t-kikuc <[email protected]> * Add GetClusterTasks func Signed-off-by: t-kikuc <[email protected]> * draft: add ecs store.go Signed-off-by: t-kikuc <[email protected]> * Add ECSApplicationLiveState to ApplicationLiveStateSnapshot and gen code Signed-off-by: t-kikuc <[email protected]> * Fix typo: ECSRun -> ECS Signed-off-by: t-kikuc <[email protected]> * draft: reporter, model Signed-off-by: t-kikuc <[email protected]> * remove applicationLister from ECS Signed-off-by: t-kikuc <[email protected]> * Define blank funcs in Getter Signed-off-by: t-kikuc <[email protected]> * impl NewStore, GetManifests, GetState, WaitForReady Signed-off-by: t-kikuc <[email protected]> * Add GetTaskDefinition() Signed-off-by: t-kikuc <[email protected]> * fix comment Signed-off-by: t-kikuc <[email protected]> * Revert "Add GetTaskDefinition()" This reverts commit cbac8ed. Signed-off-by: t-kikuc <[email protected]> * Revert "Revert "Add GetTaskDefinition()"" This reverts commit 9304b16. Signed-off-by: t-kikuc <[email protected]> * impl store.go Signed-off-by: t-kikuc <[email protected]> * Impl ecs.go > Run() Signed-off-by: t-kikuc <[email protected]> * impl ecs/report.go] Signed-off-by: t-kikuc <[email protected]> * add switch case of ECS Signed-off-by: t-kikuc <[email protected]> * fix livestatestore v1 for ecs Signed-off-by: t-kikuc <[email protected]> * Add ecs/state_test.go Signed-off-by: t-kikuc <[email protected]> * fix comments Signed-off-by: t-kikuc <[email protected]> * remove comment Signed-off-by: t-kikuc <[email protected]> * Remove TODO comment Signed-off-by: t-kikuc <[email protected]> * Remove standalone tasks states Signed-off-by: t-kikuc <[email protected]> * fix fetching ecs resources Signed-off-by: t-kikuc <[email protected]> * Fix appId key in store: use appId tag Signed-off-by: t-kikuc <[email protected]> * Remove validation of ApiVersion of ECS Signed-off-by: t-kikuc <[email protected]> * Fix updatedAt of ECS Service to pass validation Signed-off-by: t-kikuc <[email protected]> * Use VersionV1Beta1 for ECS states Signed-off-by: t-kikuc <[email protected]> * Revert "Remove validation of ApiVersion of ECS" This reverts commit e6b1ee6. Signed-off-by: t-kikuc <[email protected]> * Fix comments Signed-off-by: t-kikuc <[email protected]> * fix pipedv1 Signed-off-by: t-kikuc <[email protected]> * fix test: add apiversion, updatedat Signed-off-by: t-kikuc <[email protected]> * remove comment-outed namespace Signed-off-by: t-kikuc <[email protected]> * Export ECSResourceState Signed-off-by: t-kikuc <[email protected]> * add ECSResourceHealthStatusIcon index.tsx Signed-off-by: t-kikuc <[email protected]> * Add ECSResource index.tsx Signed-off-by: t-kikuc <[email protected]> * Add ECSResourceDetail index.tsx Signed-off-by: t-kikuc <[email protected]> * Add ECSStateView index.tsx Signed-off-by: t-kikuc <[email protected]> * Add ECS as supported kind for livestate UI Signed-off-by: t-kikuc <[email protected]> * Use ID for ResourceState of taskset and task Signed-off-by: t-kikuc <[email protected]> * Fix nits: arrange import section Signed-off-by: t-kikuc <[email protected]> * Fix graph Signed-off-by: t-kikuc <[email protected]> * fix lint/web by `make lint/web FIX=true` Signed-off-by: t-kikuc <[email protected]> * Remove ApiVersion & Namespace from ECSResourceState Signed-off-by: t-kikuc <[email protected]> * Remove ApiVersion from ECSStateView Signed-off-by: t-kikuc <[email protected]> * fix indent Signed-off-by: t-kikuc <[email protected]> * [debug] add debug logs Signed-off-by: t-kikuc <[email protected]> * add dummyApplicationLiveState of ecs Signed-off-by: t-kikuc <[email protected]> * Revert "[debug] add debug logs" This reverts commit 7926720. Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>

Signed-off-by: Yoshiki Fujikane <[email protected]>

… as much as possible (#5096) Signed-off-by: Yoshiki Fujikane <[email protected]>

Signed-off-by: khanhtc1202 <[email protected]>

* Fix 'ImageURI' -> 'Image' Signed-off-by: t-kikuc <[email protected]> * Fix field names from UpperCamelCase to lowerCamelCase Signed-off-by: t-kikuc <[email protected]> * Fix link title: 'Configuration' -> 'Configuring' Signed-off-by: t-kikuc <[email protected]> * Move link of 'Configuring Lambda application' to function.yaml area Signed-off-by: t-kikuc <[email protected]> * Fix field names from UpperCamelCase to lowerCamelCase: v0.46.x Signed-off-by: t-kikuc <[email protected]> * fix 'IDs' -> 'Ids' Signed-off-by: t-kikuc <[email protected]> * Fix Required values and add explanation Signed-off-by: t-kikuc <[email protected]> * Fix header levels under function.yaml Signed-off-by: t-kikuc <[email protected]> * fix '[[]Architecture]' to '[][Architecture]' Signed-off-by: t-kikuc <[email protected]> * Fix 'sourceCode' to 'source', although its type name is SourceCode in function.go Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: t-kikuc <[email protected]>

Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.40. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.40) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…mpatible (#5097) * Bump github.com/docker/docker Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.9+incompatible to 26.1.4+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.9...v26.1.4) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Manually update docker/cli to pass the tests build errors Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <[email protected]>

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Use LRUCache for Application Manifests Cache Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Use not constant but config value Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>

Signed-off-by: khanhtc1202 <[email protected]>

…c-pipedv1-planner Signed-off-by: khanhtc1202 <[email protected]>

github-actions · 2024-08-05T02:46:44Z

No GitHub releases will be created one this pull request got merged. Because the following tags were already created before.

v0.48.4

POC Piped v1 planner with plugin deployment interface

31fb9e5

Signed-off-by: khanhtc1202 <[email protected]>

khanhtc1202 marked this pull request as ready for review July 25, 2024 11:50

khanhtc1202 requested review from nghialv, kentakozuka, ffjlabo, t-kikuc and Warashi as code owners July 25, 2024 11:50

github-actions bot added area/go area/pipedv1 labels Jul 25, 2024

khanhtc1202 added do-not-merge/wip and removed area/go area/pipedv1 labels Jul 25, 2024

ffjlabo and others added 10 commits July 25, 2024 18:51

Add typecheck for typescript on lint/web (#5073)

5dc4ee3

Signed-off-by: Yoshiki Fujikane <[email protected]>

Add workflow for patch release (#5079)

98093d2

Signed-off-by: Yoshiki Fujikane <[email protected]>

Add user info for cherry-pick (#5080)

69f4842

Signed-off-by: Yoshiki Fujikane <[email protected]>

Add quiet option for cherry-pick (#5081)

b6e9a2c

Signed-off-by: Yoshiki Fujikane <[email protected]>

Add sign off option for git cherry-pick (#5083)

020726a

Signed-off-by: Yoshiki Fujikane <[email protected]>

add ci rule for release branch (#5085)

6dcca16

Signed-off-by: Yoshiki Fujikane <[email protected]>

Remove platform provider migration ops task (#5065)

46b475c

Signed-off-by: khanhtc1202 <[email protected]>

Release/init v0.48.3 (#5090)

739ccb0

Signed-off-by: t-kikuc <[email protected]>

Fix typo

7cd5d5c

Signed-off-by: khanhtc1202 <[email protected]>

github-actions bot added area/go area/pipedv1 labels Jul 29, 2024

Fix missing args

cfb6dee

Signed-off-by: khanhtc1202 <[email protected]>

khanhtc1202 and others added 4 commits July 29, 2024 16:56

Change deploysource generic application config to pointer

7142c23

Signed-off-by: khanhtc1202 <[email protected]>

ffjlabo and others added 10 commits July 30, 2024 06:41

Remove unnecesarry property (#5095)

915a632

Signed-off-by: Yoshiki Fujikane <[email protected]>

Set fetch-depth to 0 to create correct patches during git cherry-pick…

8944de2

… as much as possible (#5096) Signed-off-by: Yoshiki Fujikane <[email protected]>

Add buildQuickSyncStages impl

c47239b

Signed-off-by: khanhtc1202 <[email protected]>

[bot] Update contributors (#5098)

2730c25

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: t-kikuc <[email protected]>

Fix firestore index (#5100)

23d338f

Signed-off-by: Yoshiki Fujikane <[email protected]>

Update RELEASE to v0.48.4 (#5104)

9709438

Signed-off-by: Yoshiki Fujikane <[email protected]>

khanhtc1202 mentioned this pull request Aug 3, 2024

Update plugin deployment api #5110

Merged

khanhtc1202 and others added 9 commits August 5, 2024 10:00

Remove deleted related MySQL application index (#5102)

dcf8cde

Signed-off-by: khanhtc1202 <[email protected]>

Add note to application delete field (#5101)

9ec2503

Signed-off-by: khanhtc1202 <[email protected]>

Update plugin deployment api (#5110)

f5dcaa4

POC Piped v1 planner with plugin deployment interface

74ea84a

Signed-off-by: khanhtc1202 <[email protected]>

Fix typo

c030bf7

Signed-off-by: khanhtc1202 <[email protected]>

Fix missing args

0cbcf33

Signed-off-by: khanhtc1202 <[email protected]>

Change deploysource generic application config to pointer

88a2cbd

Signed-off-by: khanhtc1202 <[email protected]>

Rebase master

c92e068

Signed-off-by: khanhtc1202 <[email protected]>

Merge branch 'poc-pipedv1-planner' of github.com:pipe-cd/pipe into po…

8b0c246

…c-pipedv1-planner Signed-off-by: khanhtc1202 <[email protected]>

github-actions bot added area/web area/build labels Aug 5, 2024

khanhtc1202 closed this Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

POC Piped v1 planner with plugin deployment interface #5074

POC Piped v1 planner with plugin deployment interface #5074

khanhtc1202 commented Jul 25, 2024 •

edited

Loading

codecov bot commented Jul 29, 2024 •

edited

Loading

github-actions bot commented Aug 5, 2024

POC Piped v1 planner with plugin deployment interface #5074

POC Piped v1 planner with plugin deployment interface #5074

Conversation

khanhtc1202 commented Jul 25, 2024 • edited Loading

codecov bot commented Jul 29, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 5, 2024

khanhtc1202 commented Jul 25, 2024 •

edited

Loading

codecov bot commented Jul 29, 2024 •

edited

Loading