Triplelift Bid Adapter: get opeCloud data from local storage #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch TL Prebid up to the upstream
…acyFpd TL-26965: deprecate getLegacyFpd
…e-update TL-19850 Finished log error logic around floors functionality
…pe-to-prebid-adapter TL-27859: add frame type to prebid adapter
…d-frame-type-to-prebid-adapter Revert "TL-27859: add frame type to prebid adapter"
TL-26984: 1PlusX boilerplate - ALT
1 task
patmmccann
approved these changes
Jun 8, 2022
|
@nllerandi3lift feel free to resubmit on 6.29.x-legacy branch if this is important to your company; we'll see legacy releases continue for a few weeks |
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
…8542) * TL-19850 Finished log error logic around floors functionality * deprecates getlegacyFpd * remove console log * TL-19850 Changed functionlity of tests * restore logErrorSpy aftereach * passes 1px segments * array and malformed json check * spell check * single quotes * TL-27574 Second draft of implementing 1plusx logic * cleanup around fetchOnePlusX * replaces segment for ext * ext should be object * tests * update localstorage key name * rename to opecloud * add frametype to tlBidAdapter * removes comments * clean up + no frame ft * addressing feedback * Revert "TL-27859: add frame type to prebid adapter" * cleanup * updates tests to work with prebid 7 * permission to access storage * reset prebid global Co-authored-by: Dan Goldin <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]> Co-authored-by: gbalboa0 <[email protected]> Co-authored-by: gbalboa0 <[email protected]>
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…8542) * TL-19850 Finished log error logic around floors functionality * deprecates getlegacyFpd * remove console log * TL-19850 Changed functionlity of tests * restore logErrorSpy aftereach * passes 1px segments * array and malformed json check * spell check * single quotes * TL-27574 Second draft of implementing 1plusx logic * cleanup around fetchOnePlusX * replaces segment for ext * ext should be object * tests * update localstorage key name * rename to opecloud * add frametype to tlBidAdapter * removes comments * clean up + no frame ft * addressing feedback * Revert "TL-27859: add frame type to prebid adapter" * cleanup * updates tests to work with prebid 7 * permission to access storage * reset prebid global Co-authored-by: Dan Goldin <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]> Co-authored-by: gbalboa0 <[email protected]> Co-authored-by: gbalboa0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Allows for our bid adapter to pick up the opeCloud localStorage (a Triplelift technology) and add to the bid request. This localStorage is set independently of Prebid.
Includes 3 tests:
To Do