Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH 0022-Fix-elbv2-target-group-read-to-workaround-2517.patch #2749

Open
t0yv0 opened this issue Aug 28, 2023 · 3 comments
Open

PATCH 0022-Fix-elbv2-target-group-read-to-workaround-2517.patch #2749

t0yv0 opened this issue Aug 28, 2023 · 3 comments
Labels
area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Aug 28, 2023

Tracking context on upstream patch 0025-Fix-elbv2-target-group-read.patch here.

@t0yv0
Copy link
Member Author

t0yv0 commented Aug 28, 2023

Cited workaround for #2517, curious if can be fixed in a different way

@t0yv0 t0yv0 added area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user labels Aug 28, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Jan 20, 2024

This needs a test still, I'm not aware that we have a test for this.

t0yv0 added a commit that referenced this issue Jan 23, 2024
Fixes #3253

This PR upgrades the provider to match upstream provider version
v5.32.0.

List of unusual things that defeated upgrade-provider and required
manual intervention:

- The patch for elbv2 target workaround in #2517 does not apply cleanly
to new upstream, had to be redone; I've tested manually that 2517 does
not reproduce on top of the new provider, but need to backlog adding a
test for it; the relevant ticket is in
#2749

- Upstream is gradually removing AWS Go SDK v1. This affected legacy
bucket resource that Pulumi retains in spite of upstream having it
removed. This is now working again but required another invasive patch
to undo upstream changes.

- New "verified permissions" module needed to be registered in
resources.go to support automatic module inference.

- Several new Plugin Framework based resources required patching to
support tags; this is slowing us down until we can implement
#2962

- Run test of provider shim was breaking as it didn't get all the
dependencies, now fixed

- Patch from #3290 wouldn't
apply because of wrong format (`make upstream.rebase` broken) - had to
reformat it

- doc_edits.go would keep appending edits to replacements.json; this is fixed
@t0yv0 t0yv0 changed the title PATCH 0025-Fix-elbv2-target-group-read.patch PATCH 0022-Fix-elbv2-target-group-read-to-workaround-2517.patch Mar 25, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 24, 2024

This is now tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/patch An issue describing an existing patch on upstream and the criteria to close it. kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

1 participant