Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-aws to v5.32.0 #3253

Closed
pulumi-bot opened this issue Jan 11, 2024 · 1 comment · Fixed by #3292
Closed

Upgrade terraform-provider-aws to v5.32.0 #3253

pulumi-bot opened this issue Jan 11, 2024 · 1 comment · Fixed by #3292
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link
Contributor

Release details: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.32.0

@pulumi-bot pulumi-bot added the kind/enhancement Improvements or new features label Jan 11, 2024
@iwahbe iwahbe self-assigned this Jan 12, 2024
@t0yv0 t0yv0 assigned t0yv0 and unassigned iwahbe Jan 19, 2024
@t0yv0
Copy link
Member

t0yv0 commented Jan 19, 2024

Picking this up now I understand there's some complications with legacy bucket. I'll have a look.

t0yv0 added a commit that referenced this issue Jan 23, 2024
Fixes #3253

This PR upgrades the provider to match upstream provider version
v5.32.0.

List of unusual things that defeated upgrade-provider and required
manual intervention:

- The patch for elbv2 target workaround in #2517 does not apply cleanly
to new upstream, had to be redone; I've tested manually that 2517 does
not reproduce on top of the new provider, but need to backlog adding a
test for it; the relevant ticket is in
#2749

- Upstream is gradually removing AWS Go SDK v1. This affected legacy
bucket resource that Pulumi retains in spite of upstream having it
removed. This is now working again but required another invasive patch
to undo upstream changes.

- New "verified permissions" module needed to be registered in
resources.go to support automatic module inference.

- Several new Plugin Framework based resources required patching to
support tags; this is slowing us down until we can implement
#2962

- Run test of provider shim was breaking as it didn't get all the
dependencies, now fixed

- Patch from #3290 wouldn't
apply because of wrong format (`make upstream.rebase` broken) - had to
reformat it

- doc_edits.go would keep appending edits to replacements.json; this is fixed
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
3 participants