Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Plugin Framework tags_all Computed attribute without patches #2962

Open
t0yv0 opened this issue Nov 7, 2023 · 0 comments · May be fixed by #4151
Open

Edit Plugin Framework tags_all Computed attribute without patches #2962

t0yv0 opened this issue Nov 7, 2023 · 0 comments · May be fixed by #4151
Assignees
@t0yv0
Labels
kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Nov 7, 2023

Tracking automation debt introduced in #2944

The new tag handling strategy requires Plugin Framework resources to have tags_all attribute be not-Computed. This is not currently elegantly handled, requiring new patches every time more resources are served from the Plugin Framework. It would be ideal to not require patches.

Possible implementation angles:

  • dynamically modify the PF Provider on startup
  • automate upstream editing with upstream-tools or similar
  • figure out a way to compress multiple patches into a one "forever" patch
@t0yv0 t0yv0 mentioned this issue Nov 7, 2023
Merged
@t0yv0 t0yv0 added this to the 0.97 milestone Nov 7, 2023
@mikhailshilkov mikhailshilkov added the kind/engineering Work that is not visible to an external user label Nov 10, 2023
@iwahbe iwahbe mentioned this issue Dec 14, 2023
Merged
@lukehoban lukehoban modified the milestones: 0.97, 0.98 Dec 20, 2023
@t0yv0 t0yv0 mentioned this issue Jan 20, 2024
Merged
t0yv0 added a commit that referenced this issue Jan 23, 2024
@t0yv0
Upgrade terraform provider aws to v5.32.0 (#3292)
9335f62 
Fixes #3253

This PR upgrades the provider to match upstream provider version
v5.32.0.

List of unusual things that defeated upgrade-provider and required
manual intervention:

- The patch for elbv2 target workaround in #2517 does not apply cleanly
to new upstream, had to be redone; I've tested manually that 2517 does
not reproduce on top of the new provider, but need to backlog adding a
test for it; the relevant ticket is in
#2749

- Upstream is gradually removing AWS Go SDK v1. This affected legacy
bucket resource that Pulumi retains in spite of upstream having it
removed. This is now working again but required another invasive patch
to undo upstream changes.

- New "verified permissions" module needed to be registered in
resources.go to support automatic module inference.

- Several new Plugin Framework based resources required patching to
support tags; this is slowing us down until we can implement
#2962

- Run test of provider shim was breaking as it didn't get all the
dependencies, now fixed

- Patch from #3290 wouldn't
apply because of wrong format (`make upstream.rebase` broken) - had to
reformat it

- doc_edits.go would keep appending edits to replacements.json; this is fixed
@lukehoban lukehoban modified the milestones: 0.98, 0.100 Feb 13, 2024
@t0yv0 t0yv0 linked a pull request Jul 1, 2024 that will close this issue
Open
@t0yv0 t0yv0 self-assigned this Jul 1, 2024
@t0yv0 t0yv0 modified the milestones: 0.100, 0.107 Jul 1, 2024
@mjeffryes mjeffryes modified the milestones: 0.107, 0.108 Jul 24, 2024
@mjeffryes mjeffryes removed this from the 0.108 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automate removing Computed on tags_all for PF resources pulumi/pulumi-aws
4 participants
@t0yv0 @lukehoban @mjeffryes @mikhailshilkov