-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module version for Go package to v5. #285
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
During a major version upgrade, we usually disable Go tests - can we merge #284 first, and then add the test by itself? |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Found 31 breaking changes: |
Superseded by #284. |
The version number was still v4 in
sdk/go.mod
even after this was updated to v5. This made the package unusable from Go.Also added a test to ensure we test consuming this package from Go.
Fixes #276.
Fixes pulumi/templates#481.