Fixes #1546 #1558
Merged
Fixes #1546 #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks JudahGabriel for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
|
Note: VSCode reformatted the file, making it appear to have lots of changes. But in fact, the only change is line 713: https://github.com/pwa-builder/PWABuilder/pull/1558/files#diff-d8b273a6f3d7964a4731a6ba4122cdd9705c46ff228ee7c47d374cb3836b0a1aR713 |
jgw96
approved these changes
Mar 25, 2021
jgw96
added a commit
that referenced
this pull request
Mar 25, 2021
* Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * PWABuilder MacOS v2 (#1286) * env change * added macos platform code usage, need to work through a CORS issue. * zipAll from axios to fetch (#1289) Co-authored-by: Justin Willis <[email protected]> * Refactored score cards. Added additional checks. * Added service worker fallback (#1284) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * fix(): small typescript error * chore(): update docker container to node 12 * Update featured.json (#1295) Fix a typo! Co-authored-by: Leonardo Lee <[email protected]> * Casing fix. Removed unused CSS build warnings * Fix for build (#1306) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * Casing fix. Removed unused CSS build warnings * fix(): sw picker form has min-height to avoid "pop-in" * refactor(): move to new service worker server + simplify * v2 web packaging (#1301) * v2 web packaging * for documentation sake, but something for the future * new endpoints Co-authored-by: Justin Willis <[email protected]> * Added safe URL fetching fallback (#1315) * Added safe URL fetching fallback * Better service name * Fix for #1336 (#1344) * Initial work towards nav fix * Added UI for Play billing, location delegation (#1346) * Final fix for edit manifest nav * Fixes #1365 (#1380) * Additional windows platform fields (#1448) * Adds package language and start_url to Windows * I'm writing TS, not C# * Fixed label name collision * Removed redis sync. * chore(): remove deprecated legacy edge platform * Fixes #1546 (#1558) Co-authored-by: Judah Gabriel Himango <[email protected]> Co-authored-by: Leonardo Lee <[email protected]> Co-authored-by: Roman Rokon <[email protected]>
jgw96
added a commit
that referenced
this pull request
Mar 30, 2021
* Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * PWABuilder MacOS v2 (#1286) * env change * added macos platform code usage, need to work through a CORS issue. * zipAll from axios to fetch (#1289) Co-authored-by: Justin Willis <[email protected]> * Refactored score cards. Added additional checks. * Added service worker fallback (#1284) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * fix(): small typescript error * chore(): update docker container to node 12 * Update featured.json (#1295) Fix a typo! Co-authored-by: Leonardo Lee <[email protected]> * Casing fix. Removed unused CSS build warnings * Fix for build (#1306) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * Casing fix. Removed unused CSS build warnings * fix(): sw picker form has min-height to avoid "pop-in" * refactor(): move to new service worker server + simplify * v2 web packaging (#1301) * v2 web packaging * for documentation sake, but something for the future * new endpoints Co-authored-by: Justin Willis <[email protected]> * Added safe URL fetching fallback (#1315) * Added safe URL fetching fallback * Better service name * Fix for #1336 (#1344) * Initial work towards nav fix * Added UI for Play billing, location delegation (#1346) * Final fix for edit manifest nav * Fixes #1365 (#1380) * Additional windows platform fields (#1448) * Adds package language and start_url to Windows * I'm writing TS, not C# * Fixed label name collision * Removed redis sync. * chore(): remove deprecated legacy edge platform * Fixes #1546 (#1558) * Fixes #1474, screenshots have correct sizes (#1577) * Fixes #1570, language selection values (#1579) Co-authored-by: Judah Gabriel Himango <[email protected]> Co-authored-by: Leonardo Lee <[email protected]> Co-authored-by: Roman Rokon <[email protected]>
jgw96
added a commit
that referenced
this pull request
Apr 19, 2021
* Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * PWABuilder MacOS v2 (#1286) * env change * added macos platform code usage, need to work through a CORS issue. * zipAll from axios to fetch (#1289) Co-authored-by: Justin Willis <[email protected]> * Refactored score cards. Added additional checks. * Added service worker fallback (#1284) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * fix(): small typescript error * chore(): update docker container to node 12 * Update featured.json (#1295) Fix a typo! Co-authored-by: Leonardo Lee <[email protected]> * Casing fix. Removed unused CSS build warnings * Fix for build (#1306) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * Casing fix. Removed unused CSS build warnings * fix(): sw picker form has min-height to avoid "pop-in" * refactor(): move to new service worker server + simplify * v2 web packaging (#1301) * v2 web packaging * for documentation sake, but something for the future * new endpoints Co-authored-by: Justin Willis <[email protected]> * Added safe URL fetching fallback (#1315) * Added safe URL fetching fallback * Better service name * Fix for #1336 (#1344) * Initial work towards nav fix * Added UI for Play billing, location delegation (#1346) * Final fix for edit manifest nav * Fixes #1365 (#1380) * Additional windows platform fields (#1448) * Adds package language and start_url to Windows * I'm writing TS, not C# * Fixed label name collision * Removed redis sync. * chore(): remove deprecated legacy edge platform * Fixes #1546 (#1558) * Fixes #1474, screenshots have correct sizes (#1577) * Fixes #1570, language selection values (#1579) * Better screenshots #1474 (#1589) * chore(): update samsung platform to reflect changes * Completed Samsung UI update Co-authored-by: Leonardo Lee <[email protected]> Co-authored-by: Justin Willis <[email protected]> Co-authored-by: Roman Rokon <[email protected]>
jgw96
added a commit
that referenced
this pull request
May 3, 2021
* Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * PWABuilder MacOS v2 (#1286) * env change * added macos platform code usage, need to work through a CORS issue. * zipAll from axios to fetch (#1289) Co-authored-by: Justin Willis <[email protected]> * Refactored score cards. Added additional checks. * Added service worker fallback (#1284) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * fix(): small typescript error * chore(): update docker container to node 12 * Update featured.json (#1295) Fix a typo! Co-authored-by: Leonardo Lee <[email protected]> * Casing fix. Removed unused CSS build warnings * Fix for build (#1306) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * Casing fix. Removed unused CSS build warnings * fix(): sw picker form has min-height to avoid "pop-in" * refactor(): move to new service worker server + simplify * v2 web packaging (#1301) * v2 web packaging * for documentation sake, but something for the future * new endpoints Co-authored-by: Justin Willis <[email protected]> * Added safe URL fetching fallback (#1315) * Added safe URL fetching fallback * Better service name * Fix for #1336 (#1344) * Initial work towards nav fix * Added UI for Play billing, location delegation (#1346) * Final fix for edit manifest nav * Fixes #1365 (#1380) * Additional windows platform fields (#1448) * Adds package language and start_url to Windows * I'm writing TS, not C# * Fixed label name collision * Removed redis sync. * chore(): remove deprecated legacy edge platform * Fixes #1546 (#1558) * Fixes #1474, screenshots have correct sizes (#1577) * Fixes #1570, language selection values (#1579) * Better screenshots #1474 (#1589) * chore(): update samsung platform to reflect changes * Completed Samsung UI update * chore(): update action based on findings from api v2 PRs are now handled specifically for both dev and prod * Update link to IARC rating ID (#1657) * Added offline check fallback (#1660) Co-authored-by: Leonardo Lee <[email protected]> Co-authored-by: Justin Willis <[email protected]> Co-authored-by: Roman Rokon <[email protected]> Co-authored-by: Steven Sinatra <[email protected]>
jgw96
added a commit
that referenced
this pull request
May 3, 2021
* Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * PWABuilder MacOS v2 (#1286) * env change * added macos platform code usage, need to work through a CORS issue. * zipAll from axios to fetch (#1289) Co-authored-by: Justin Willis <[email protected]> * Refactored score cards. Added additional checks. * Added service worker fallback (#1284) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * fix(): small typescript error * chore(): update docker container to node 12 * Update featured.json (#1295) Fix a typo! Co-authored-by: Leonardo Lee <[email protected]> * Casing fix. Removed unused CSS build warnings * Fix for build (#1306) * Added service worker fallback * Fix comment, added missing await * Moving offline check into separate proc * Refactored score cards. Added additional checks. * Casing fix. Removed unused CSS build warnings * fix(): sw picker form has min-height to avoid "pop-in" * refactor(): move to new service worker server + simplify * v2 web packaging (#1301) * v2 web packaging * for documentation sake, but something for the future * new endpoints Co-authored-by: Justin Willis <[email protected]> * Added safe URL fetching fallback (#1315) * Added safe URL fetching fallback * Better service name * Fix for #1336 (#1344) * Initial work towards nav fix * Added UI for Play billing, location delegation (#1346) * Final fix for edit manifest nav * Fixes #1365 (#1380) * Additional windows platform fields (#1448) * Adds package language and start_url to Windows * I'm writing TS, not C# * Fixed label name collision * Removed redis sync. * chore(): remove deprecated legacy edge platform * Fixes #1546 (#1558) * Fixes #1474, screenshots have correct sizes (#1577) * Fixes #1570, language selection values (#1579) * Better screenshots #1474 (#1589) * chore(): update samsung platform to reflect changes * Completed Samsung UI update * chore(): update action based on findings from api v2 PRs are now handled specifically for both dev and prod * Update link to IARC rating ID (#1657) * Added offline check fallback (#1660) * fix(): action runs on merges to prod Co-authored-by: Judah Gabriel Himango <[email protected]> Co-authored-by: Leonardo Lee <[email protected]> Co-authored-by: Roman Rokon <[email protected]> Co-authored-by: Steven Sinatra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1546, changes the info text for Android signing options to the modern recommendations.