Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to IARC rating ID #1657

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Update link to IARC rating ID #1657

merged 1 commit into from
Apr 26, 2021

Conversation

diagramatics
Copy link

PR Type

  • Bugfix
  • Documentation content changes

Describe the current behavior?

Jut a quick PR, The current link is broken since the content has been moved to a new URL.

Describe the new behavior?

The new URL is https://www.w3.org/TR/manifest-app-info/#iarc_rating_id-member

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target master branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@ghost
Copy link

ghost commented Apr 25, 2021

Thanks diagramatics for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned davrous Apr 25, 2021
Copy link
Contributor

@jgw96 jgw96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We always appreciate the help!

@jgw96 jgw96 changed the base branch from master to dev April 26, 2021 23:04
@jgw96 jgw96 merged commit 7b997a1 into pwa-builder:dev Apr 26, 2021
jgw96 added a commit that referenced this pull request May 3, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <[email protected]>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <[email protected]>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <[email protected]>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

* chore(): update action based on findings from api v2

PRs are now handled specifically for both dev and prod

* Update link to IARC rating ID (#1657)

* Added offline check fallback (#1660)

Co-authored-by: Leonardo Lee <[email protected]>
Co-authored-by: Justin Willis <[email protected]>
Co-authored-by: Roman Rokon <[email protected]>
Co-authored-by: Steven Sinatra <[email protected]>
jgw96 added a commit that referenced this pull request May 3, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <[email protected]>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <[email protected]>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <[email protected]>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

* chore(): update action based on findings from api v2

PRs are now handled specifically for both dev and prod

* Update link to IARC rating ID (#1657)

* Added offline check fallback (#1660)

* fix(): action runs on merges to prod

Co-authored-by: Judah Gabriel Himango <[email protected]>
Co-authored-by: Leonardo Lee <[email protected]>
Co-authored-by: Roman Rokon <[email protected]>
Co-authored-by: Steven Sinatra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants