Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #1679

Merged
merged 48 commits into from
May 3, 2021
Merged

Dev #1679

merged 48 commits into from
May 3, 2021

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented May 3, 2021

Fixes #

PR Type

Describe the current behavior?

Describe the new behavior?

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target master branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

JudahGabriel and others added 30 commits December 7, 2020 21:22
* env change

* added macos platform code usage, need to work through a CORS issue.
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.
Fix a typo!

Co-authored-by: Leonardo Lee <[email protected]>
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings
* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <[email protected]>
* Added safe URL fetching fallback

* Better service name
* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision
@ghost
Copy link

ghost commented May 3, 2021

Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned davrous May 3, 2021
@jgw96 jgw96 merged commit 1bc9979 into master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants