refactor(authentication): discovery-148 replace empty-state #113

cdcabrera · 2022-07-06T19:24:04Z

What's included

Bug Fixes

confirmationModal expand behavior, allow children

Code Refactoring

authentication discovery-148 replace empty-state

How to test

Example

BEFORE

AFTER

Updates issue/story

DISCOVERY-148

#99
#92

…ds#113)

codecov-commenter · 2022-07-06T19:27:40Z

Codecov Report

❗ No coverage uploaded for pull request base (dev@5228526). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #113   +/-   ##
======================================
  Coverage       ?   72.18%           
======================================
  Files          ?       95           
  Lines          ?     3063           
  Branches       ?      834           
======================================
  Hits           ?     2211           
  Misses         ?      754           
  Partials       ?       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5228526...ba861e4. Read the comment docs.

bclarhk

Love it. Same icon alignment caveat as the rest of the alerts.
👨‍🍳 💋

src/components/authentication/__tests__/__snapshots__/authentication.test.js.snap

…ds#113)

bclarhk

Css text alignment issues, but

author CD Cabrera <[email protected]> 1654528943 -0400 committer jenny-s51 <[email protected]> 1659366125 -0400 fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) refactor(services): discovery-8 minor config restructure (quipucords#82) * service config, allow opts, fallback xhr timeout * api calls, config wrapper function, named imports refactor(redux): discovery-8 middleware, hooks, restructure (quipucords#82) * helpers, aggregatedError func for redux hooks * redux actions, named exports * redux hooks, useReactRedux * redux middleware, middleware export, multi-actions * store, move middleware, named export fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) refactor(authentication): discovery-148 pf4 alert, locale (quipucords#112) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(refreshTimeButton): discovery-149 pf4 button, icon (quipucords#114) refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state refactor(toastNotificationsList): discovery-148, pf4 alert (quipucords#115) * build, dotenv toast timeout * components, adjust alertType to alert variant * helpers, expose toast timeout * toastNotificationsList, pf4 alert, alertGroup * toastNotificationsReducer, adjust pause, resume fix(testing): expand toastNotificationsList snapshots (quipucords#115) refactor(sources): discovery-148 pf4 empty-state (quipucords#120) * locale, add empty-state strings * sources, pf4 empty-state refactor(creds,sources,scans): discovery-149 emptyState grid (quipucords#121) * credentials, sources, scansEmptyState, remove grid fix(i18n): discovery-8 partial context into keys (quipucords#124) feat(wizard): discovery-153 pf4 wizard wrapper (quipucords#124) * confirmationModal, pass isContentOnly * modal, add isContentOnly, removes padding * wizard, consistent pf4 wrapper, allow modal sizing refactor(addSourceWizard): discovery-153, pf4 wizard (quipucords#124) * locale, wizard form strings * addSourceWizard, Constants, restructure steps * addSourceWizardStepThree, add empty-state * styling, restructure pf3 styling wizard form refactor(scanHostList): discovery-148, pf4 empty-state (quipucords#125) refactor(pagination): wip refactor(pagination): use PF4 component refactor(pagination): update snapshots refactor(pagination): update test refactor(pagination): update test refactor(creds,sources,scans): discovery-149 pf4 grid, list (quipucords#126) * credentialsListItem, grid to list, tooltip * credentials, removed grid * scanHostList, grid to list * scanSourceList nested list with icon * sourceCredentialsList, list with icon refactor(dropdownSelect): discovery-152 pf4 select, dropdown (quipucords#127) * addSourceWizardStepTwo, options, pf4 select list * createCredentialDialog, pf4 select list * dropdownSelect, use Curiosity pf4 select wrapper * locale, option strings refactor(dropdownSelect): discovery-152 pf4 dropdown (quipucords#130) feat(addCredentialType): discovery-152 button selector (quipucords#130) refactor(credentials): discovery-152, pf4 dropdown (quipucords#130) * credentials, pf4 button, addCredentialType * credentialsEmptyState, addCredentialType * locale, cred strings

author CD Cabrera <[email protected]> 1654528943 -0400 committer jenny-s51 <[email protected]> 1659366125 -0400 fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) refactor(services): discovery-8 minor config restructure (quipucords#82) * service config, allow opts, fallback xhr timeout * api calls, config wrapper function, named imports refactor(redux): discovery-8 middleware, hooks, restructure (quipucords#82) * helpers, aggregatedError func for redux hooks * redux actions, named exports * redux hooks, useReactRedux * redux middleware, middleware export, multi-actions * store, move middleware, named export fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) refactor(authentication): discovery-148 pf4 alert, locale (quipucords#112) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(refreshTimeButton): discovery-149 pf4 button, icon (quipucords#114) refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state refactor(toastNotificationsList): discovery-148, pf4 alert (quipucords#115) * build, dotenv toast timeout * components, adjust alertType to alert variant * helpers, expose toast timeout * toastNotificationsList, pf4 alert, alertGroup * toastNotificationsReducer, adjust pause, resume fix(testing): expand toastNotificationsList snapshots (quipucords#115) refactor(sources): discovery-148 pf4 empty-state (quipucords#120) * locale, add empty-state strings * sources, pf4 empty-state refactor(creds,sources,scans): discovery-149 emptyState grid (quipucords#121) * credentials, sources, scansEmptyState, remove grid fix(i18n): discovery-8 partial context into keys (quipucords#124) feat(wizard): discovery-153 pf4 wizard wrapper (quipucords#124) * confirmationModal, pass isContentOnly * modal, add isContentOnly, removes padding * wizard, consistent pf4 wrapper, allow modal sizing refactor(addSourceWizard): discovery-153, pf4 wizard (quipucords#124) * locale, wizard form strings * addSourceWizard, Constants, restructure steps * addSourceWizardStepThree, add empty-state * styling, restructure pf3 styling wizard form refactor(scanHostList): discovery-148, pf4 empty-state (quipucords#125) refactor(pagination): wip refactor(pagination): use PF4 component refactor(pagination): update snapshots refactor(pagination): update test refactor(pagination): update test refactor(creds,sources,scans): discovery-149 pf4 grid, list (quipucords#126) * credentialsListItem, grid to list, tooltip * credentials, removed grid * scanHostList, grid to list * scanSourceList nested list with icon * sourceCredentialsList, list with icon refactor(dropdownSelect): discovery-152 pf4 select, dropdown (quipucords#127) * addSourceWizardStepTwo, options, pf4 select list * createCredentialDialog, pf4 select list * dropdownSelect, use Curiosity pf4 select wrapper * locale, option strings refactor(dropdownSelect): discovery-152 pf4 dropdown (quipucords#130) feat(addCredentialType): discovery-152 button selector (quipucords#130) refactor(credentials): discovery-152, pf4 dropdown (quipucords#130) * credentials, pf4 button, addCredentialType * credentialsEmptyState, addCredentialType * locale, cred strings refactor(pagination): update snapshots

fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) refactor(services): discovery-8 minor config restructure (quipucords#82) * service config, allow opts, fallback xhr timeout * api calls, config wrapper function, named imports refactor(redux): discovery-8 middleware, hooks, restructure (quipucords#82) * helpers, aggregatedError func for redux hooks * redux actions, named exports * redux hooks, useReactRedux * redux middleware, middleware export, multi-actions * store, move middleware, named export fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) refactor(authentication): discovery-148 pf4 alert, locale (quipucords#112) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(refreshTimeButton): discovery-149 pf4 button, icon (quipucords#114) refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state fix(build): base dep package updates (quipucords#80) * build, base deps for dev functionality * build, stage, review, use pre-built image * testing, dist test, lint updates * styling, flip to sass, remove legacy css chore(build): node, workflow, docs, and tooling refs (quipucords#80) fix(build): npm updates (quipucords#80) fix(build): update react (quipucords#80) * build, update react 17, pf deps * testing, snapshots, console check fix(i18n): component loading (quipucords#80) chore(build): github badge, remove travis (quipucords#81) chore(build): post clean up, remove unused css copy (quipucords#84) fix(build): npm updates (quipucords#83) fix(build): npm update, redux middleware (quipucords#82) fix(build): discovery-8 allow repo locale files (quipucords#85) * docs, merge repo locale with docs locale files * helpers, expand noopTranslate, annotations * i18n, snapshot translate uses * i18nHelpers, translate helper, expand testing * testing, hook testing funcs fix(build): allow running review, stage parallel (quipucords#86) * build, parallel images, container names, domains * build, npm script, docker stop feat(pf4-style): discovery-8 pf4 base css, scss (quipucords#86) * build, pf4 npm updates * style, move base css files to index.scss * style, apply core pf4, overrides.scss fix(style): discovery-8 css, scss vars for color (quipucords#86) fix(testing): use i18n unit, remove integration check (quipucords#87) fix(helpers): discovery-8 consistent brand, getCurrentDate (quipucords#87) refactor(aboutModal): discovery-148 pf4 conversion (quipucords#87) * aboutModal, pf4 component conversion * locales, about modal strings chore(build): do not start with stored data, db volumes (quipucords#107) chore(build): activate eslint jsdoc (quipucords#110) fix(pf4-style): expose scss variables (quipucords#110) feat(modal): discovery-148 pf4 modal wrapper (quipucords#110) * locales, modal default string * modal, consistent pf4 wrapper, allow backdrop disable refactor(modal): discovery-148 pf4 modal wrapper (quipucords#88) * locale, button strings for modals * authentication, apply pf4 modal * confirmationModal, refactor using pf4 modal * createCredentialDialog, pf4 modal, buttons * createScanDialog, pf4 modal, buttons * credentials, pf4 modal * mergeReportsDialog, pf modal, buttons * scans, pf4 modal * sources, pf4 modal refactor(createCredentialDialog): discovery-148 pf4 alert(quipucords#108) fix(confirmationModal): expand behavior, allow children (quipucords#113) refactor(authentication): discovery-148 replace empty-state (quipucords#113) refactor(credentials): discovery-148 pf4 empty-state (quipucords#116) * locale, align empty-state strings * authentication, align with credentials * credentials, credentialsEmptyState, pf4 empty-state refactor(scans): discovery-148 pf4 empty-state (quipucords#117) * locale, align empty-state strings * scans, jobsList, sourceList, pf4 empty-state refactor(toastNotificationsList): discovery-148, pf4 alert (quipucords#115) * build, dotenv toast timeout * components, adjust alertType to alert variant * helpers, expose toast timeout * toastNotificationsList, pf4 alert, alertGroup * toastNotificationsReducer, adjust pause, resume fix(testing): expand toastNotificationsList snapshots (quipucords#115) refactor(sources): discovery-148 pf4 empty-state (quipucords#120) * locale, add empty-state strings * sources, pf4 empty-state refactor(creds,sources,scans): discovery-149 emptyState grid (quipucords#121) * credentials, sources, scansEmptyState, remove grid fix(i18n): discovery-8 partial context into keys (quipucords#124) feat(wizard): discovery-153 pf4 wizard wrapper (quipucords#124) * confirmationModal, pass isContentOnly * modal, add isContentOnly, removes padding * wizard, consistent pf4 wrapper, allow modal sizing refactor(addSourceWizard): discovery-153, pf4 wizard (quipucords#124) * locale, wizard form strings * addSourceWizard, Constants, restructure steps * addSourceWizardStepThree, add empty-state * styling, restructure pf3 styling wizard form refactor(scanHostList): discovery-148, pf4 empty-state (quipucords#125) refactor(pagination): wip refactor(pagination): use PF4 component refactor(pagination): update snapshots refactor(pagination): update test refactor(pagination): update test refactor(creds,sources,scans): discovery-149 pf4 grid, list (quipucords#126) * credentialsListItem, grid to list, tooltip * credentials, removed grid * scanHostList, grid to list * scanSourceList nested list with icon * sourceCredentialsList, list with icon refactor(dropdownSelect): discovery-152 pf4 select, dropdown (quipucords#127) * addSourceWizardStepTwo, options, pf4 select list * createCredentialDialog, pf4 select list * dropdownSelect, use Curiosity pf4 select wrapper * locale, option strings refactor(dropdownSelect): discovery-152 pf4 dropdown (quipucords#130) feat(addCredentialType): discovery-152 button selector (quipucords#130) refactor(credentials): discovery-152, pf4 dropdown (quipucords#130) * credentials, pf4 button, addCredentialType * credentialsEmptyState, addCredentialType * locale, cred strings refactor(pagination): update snapshots

cdcabrera added the pf4 Tracking for pf4 refactors label Jul 6, 2022

cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request Jul 6, 2022

fix(confirmationModal): expand behavior, allow children (quipucords#113)

a5e6185

cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request Jul 6, 2022

refactor(authentication): discovery-148 replace empty-state (quipucor…

83a5bda

…ds#113)

cdcabrera force-pushed the dis-148-emptystate branch from 2994ced to 83a5bda Compare July 6, 2022 19:26

cdcabrera requested review from bclarhk and ruda July 6, 2022 19:43

cdcabrera marked this pull request as ready for review July 6, 2022 19:43

bclarhk approved these changes Jul 6, 2022

View reviewed changes

cdcabrera commented Jul 6, 2022

View reviewed changes

src/components/authentication/__tests__/__snapshots__/authentication.test.js.snap Outdated Show resolved Hide resolved

cdcabrera added 2 commits July 6, 2022 16:34

fix(confirmationModal): expand behavior, allow children (quipucords#113)

4025ce8

refactor(authentication): discovery-148 replace empty-state (quipucor…

ba861e4

…ds#113)

cdcabrera force-pushed the dis-148-emptystate branch from 83a5bda to ba861e4 Compare July 6, 2022 20:34

bclarhk approved these changes Jul 6, 2022

View reviewed changes

cdcabrera merged commit e66e54d into quipucords:dev Jul 7, 2022

cdcabrera added a commit that referenced this pull request Jul 7, 2022

fix(confirmationModal): expand behavior, allow children (#113)

6dc704f

cdcabrera added a commit that referenced this pull request Jul 12, 2022

fix(confirmationModal): expand behavior, allow children (#113)

4ab9734

cdcabrera added a commit that referenced this pull request Jul 12, 2022

refactor(authentication): discovery-148 replace empty-state (#113)

29e5580

cdcabrera added a commit that referenced this pull request Aug 12, 2022

fix(confirmationModal): expand behavior, allow children (#113)

15777c9

cdcabrera added a commit that referenced this pull request Aug 12, 2022

refactor(authentication): discovery-148 replace empty-state (#113)

bf649d3

cdcabrera added a commit that referenced this pull request Sep 7, 2022

fix(confirmationModal): expand behavior, allow children (#113)

6f92a23

cdcabrera added a commit that referenced this pull request Sep 7, 2022

refactor(authentication): discovery-148 replace empty-state (#113)

1da65e1

cdcabrera added a commit that referenced this pull request Sep 8, 2022

fix(confirmationModal): expand behavior, allow children (#113)

940363a

cdcabrera added a commit that referenced this pull request Sep 8, 2022

refactor(authentication): discovery-148 replace empty-state (#113)

dab26cd

cdcabrera added a commit that referenced this pull request Sep 20, 2022

fix(confirmationModal): expand behavior, allow children (#113)

47975db

cdcabrera added a commit that referenced this pull request Sep 20, 2022

refactor(authentication): discovery-148 replace empty-state (#113)

ce28975

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(authentication): discovery-148 replace empty-state #113

refactor(authentication): discovery-148 replace empty-state #113

cdcabrera commented Jul 6, 2022 •

edited

Loading

codecov-commenter commented Jul 6, 2022 •

edited

Loading

bclarhk left a comment

bclarhk left a comment

refactor(authentication): discovery-148 replace empty-state #113

refactor(authentication): discovery-148 replace empty-state #113

Conversation

cdcabrera commented Jul 6, 2022 • edited Loading

What's included

Bug Fixes

Code Refactoring

How to test

Example

Updates issue/story

codecov-commenter commented Jul 6, 2022 • edited Loading

Codecov Report

bclarhk left a comment

Choose a reason for hiding this comment

bclarhk left a comment

Choose a reason for hiding this comment

cdcabrera commented Jul 6, 2022 •

edited

Loading

codecov-commenter commented Jul 6, 2022 •

edited

Loading