refactor(scans): discovery-148 pf4 empty-state

[cdcabrera]

What's included

Code Refactoring

1. scans discovery-148 pf4 empty-state

How to test

Local run check

1. update the NPM packages with $ yarn
2. $ yarn start:stage
3. navigate to the scans view, having zero scans and the initial welcome message should display
4. next add some scans then filter them so NO scans display, and confirm the empty state filter with magnifying glass displays
5. recreating the error we handled by modifying the Redux state layer... open the ./src/components/scans/scans.js file and add the two lines for , error: true, errorMessage: 'Lorem ipsum'

     const makeMapStateToProps = () => {
       const scansView = reduxSelectors.scans.makeScansView();
   
       return (state, props) => ({
         ...scansView(state, props),
         viewOptions: state.viewOptions[reduxTypes.view.SCANS_VIEW]
         error: true,
         errorMessage: 'Lorem ipsum'
      });
     ...
   

Example

Scans

BEFORE

AFTER

ScanJobsList & ScanSourceList

BEFORE

AFTER

Updates issue/story

DISCOVERY-148
#99

[cdcabrera]

Clean up and artifact creation

[bclarhk]

What changes should I be looking for in the "ScanJobsList & ScanSourceList"? Just in the expanded section? I'd normally slack you a question like this, but Slack seems to be down or blocked inside the tower...

[cdcabrera]

@bclarhk the changes to empty state are only in the content are of those two for "pending/loading" and "error", Scan Jobs List and Scan Source List.

[bclarhk]

Same css icon alignment issue. Everything else looks GTG!