Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Auto-merge branch-0.17 to branch-0.18 [skip ci] #3217

Merged
merged 10 commits into from
Dec 1, 2020

Conversation

GPUtester
Copy link
Contributor

Auto-merge triggered by push to branch-0.17 that creates a PR to keep branch-0.18 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

viclafargue and others added 10 commits November 30, 2020 10:31
)

* Enable pipeline usage for OneHotEncoder and LabelEncoder

* Changelog update
* Adding simple dask estimator notebook to demonstrate saving/loading

* Renaming and updating cells

* Updating source.rst

* Updating changelog

* Updating pickling notebook

* Review updates

* More review feedback

Co-authored-by: John Zedlewski <[email protected]>
* Fix + multiple improvements

* Update changelog

* Update model output and testing

* Check style update

* Update comments

* Test one query partition

* Check style
…dically-failing FIL test [skip ci] (#3196)

* Disable ascending=false path for sortColumnsPerRow

* DOC Update chanegelog

* Disable flaky FIL test

Co-authored-by: John Zedlewski <[email protected]>
Co-authored-by: John Zedlewski <[email protected]>
* FIX Fix EXITCODE override in test_notebooks script

* DOC Changelog update

* FIX Move bash trap to after the GTests so they fail immediately

* FIX Move codecov block to gpu build
* Fix cuDF to cuPy conversion (missing value)

* Changelog update

* Introducing fail_on_nan parameter

* Adding test with fail_on_nan=True

* Updating conversion

* Rename fail_on_nan into fail_on_null
This PR is fixing the attribute error of #3183, and additional bugs on the input type of PCA (`sparse_scipy_to_cp()` function call missed an argument) and on the shape of `self.singular_values_`.

I am also adding additional tests on the bug fixed here.

Authors:
  - Mickael Ide <[email protected]>
  - John Zedlewski <[email protected]>

Approvers:
  - Divye Gala
  - John Zedlewski

URL: #3190
…3214)

Add atol parameter to silhouette_score test to ensure consistent test behavior

Authors:
  - William Hicks <[email protected]>

Approvers:
  - John Zedlewski

URL: #3214
I found it helpful when debugging the MSE metric calculation in random forest.

Gain = Change in the metric (MSE / MAE / Gini / Entropy) that's attributed directly to each internal node (split).

Authors:
  - Hyunsu Cho <[email protected]>

Approvers:
  - John Zedlewski

URL: #3186
This PR fixes #3173 . 


With this PR it renders like below locally for me. 

![image](https://user-images.githubusercontent.com/4837571/100154855-22761e00-2e5b-11eb-9be3-173e1a53ad08.png)

Authors:
  - Vibhu Jawa <[email protected]>
  - Vibhu Jawa <[email protected]>
  - Corey J. Nolet <[email protected]>

Approvers:
  - John Zedlewski

URL: #3185
@GPUtester GPUtester requested review from a team as code owners December 1, 2020 15:36
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@GPUtester
Copy link
Contributor Author

SUCCESS - Auto-merge complete.

@GPUtester GPUtester merged commit e8a484b into branch-0.18 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants