Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Update Lightning examples to support PTL 1.5 #20562

Merged
merged 6 commits into from
Feb 12, 2022

Conversation

kaushikb11
Copy link
Contributor

Why are these changes needed?

Related issue number

To helps resolve the issues users are facing with running Lightning examples with Ray Tune Lightning-AI/pytorch-lightning#10407

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@awaelchli
Copy link

@kaushikb11 here is possibly another change we need to make:

if trainer.running_sanity_check:

it was renamed to sanity_checking. Should I send a separate PR?

@amogkam
Copy link
Contributor

amogkam commented Nov 27, 2021

@kaushikb11 can you also update the version specified here to 1.5.3- https://github.com/ray-project/ray/blob/master/python/requirements/ml/requirements_tune.txt#L32.

This will make sure that we run with the latest PTL version in our CI.

@amogkam amogkam added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Nov 27, 2021
@amogkam amogkam self-assigned this Nov 29, 2021
@bveeramani
Copy link
Member

‼️ ACTION REQUIRED ‼️

We've switched our code formatter from YAPF to Black (see #21311).

To prevent issues with merging your code, here's what you'll need to do:

  1. Install Black
pip install -I black==21.12b0
  1. Format changed files with Black
curl -o format-changed.sh https://gist.githubusercontent.com/bveeramani/42ef0e9e387b755a8a735b084af976f2/raw/7631276790765d555c423b8db2b679fd957b984a/format-changed.sh
chmod +x ./format-changed.sh
./format-changed.sh
rm format-changed.sh
  1. Commit your changes.
git add --all
git commit -m "Format Python code with Black"
  1. Merge master into your branch.
git pull upstream master
  1. Resolve merge conflicts (if necessary).

After running these steps, you'll have the updated format.sh.

@amogkam amogkam changed the title Update Lightning examples with the latest updates [tune] Update Lightning examples to support PTL 1.5 Feb 12, 2022
@amogkam amogkam merged commit 8515fdd into ray-project:master Feb 12, 2022
@amogkam amogkam removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 12, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
To helps resolve the issues users are facing with running Lightning examples with Ray Tune Lightning-AI/pytorch-lightning#10407

Co-authored-by: Amog Kamsetty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants