[tune/docs] Update custom syncer example #27252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <[email protected]>
krfricke
requested review from
richardliaw,
xwjiang2010,
amogkam,
matthewdeng,
Yard1 and
maxpumperla
as code owners
xwjiang2010
approved these changes
Jul 29, 2022
krfricke
added a commit
to krfricke/ray
that referenced
this pull request
Jul 29, 2022
There is a small bug in the docs example for custom command based syncers. This PR fixes them and adds a test to test these changes. Signed-off-by: Kai Fricke <[email protected]>
7 tasks
scv119
pushed a commit
that referenced
this pull request
Aug 2, 2022
) * [air] fix xgboost_benchmark script by passing in args (#27146) * [tune/docs] Update custom syncer example (#27252) There is a small bug in the docs example for custom command based syncers. This PR fixes them and adds a test to test these changes. Signed-off-by: Kai Fricke <[email protected]> * [tune/release] Do not use spot instances in k8s tests (#27250) Spot instances are not being booted up, so let's go without them. Signed-off-by: Kai Fricke <[email protected]> Co-authored-by: matthewdeng <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
There is a small bug in the docs example for custom command based syncers. This PR fixes them and adds a test to test these changes. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
There is a small bug in the docs example for custom command based syncers. This PR fixes them and adds a test to test these changes.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.