[Actor] [Code Quality] Add Unit Tests for Actors Sorting #34058

chaowanggg · 2023-04-04T18:22:35Z

Why are these changes needed?

Following with #33395 (comment), add a component test to improve the code quality

Related issue number

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

Signed-off-by: chaowang <[email protected]>

…ctor_state

Signed-off-by: chaowang <[email protected]>

Deletes the old IA. Deleted all routes from old IA that were no longer used. (One remained: CmdResult) Moved all the new IA routes from /new/<route> to /<route> Deleted all components that were no longer used as a result of removing old IA routes Deleted all parameters for "newIA" and removed the code paths where newIA is false Deleted the dark theme from the the app (theme was only adjustable in the old IA) I manually tested every single button to make sure links still worked. Our testing on the dashboard is not quite good enough yet (it's getting better) to trust the tests to catch all possible bugs here. The earlier we get this into nightly, the more manual testing from users we can get. Signed-off-by: chaowang <[email protected]>

…project#31578) Why are these changes needed? Changes made to batch_tuning.ipynb and batch_forecasting.ipynb: Update notebook texts, make steps clearer. Tune outputs only showing SMOKE_TEST outputs. --------- Signed-off-by: Christy Bergman <[email protected]> Signed-off-by: Antoni Baum <[email protected]> Co-authored-by: Antoni Baum <[email protected]> Signed-off-by: chaowang <[email protected]>

…ct#33242) Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: chaowang <[email protected]>

Fix the test run. Signed-off-by: chaowang <[email protected]>

70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: chaowang <[email protected]>

…ject#33370) The naming of different path-related components in Ray Tune is currently messy. For instance, `Experiment.local_dir` refers to main results directory, e.g. `~/ray_results`, while `Trial.local_dir` refers to the experiment directory, e.g. `~/ray_results/experiment`. The same is true for properties, where it's unclear if it refers to the object's sub directory or to its parent directory. To disentangle this information, this PR introduces a new naming convention. - All entities receiving a "parent path" receive it in a unambiguous naming scheme. - For instance, `Experiment(storage_path)`, `TrialRunner(experiment_path)`, `Trial(experiment_path)` - Outputs are also normalized. E.g. `Trial.remote_experiment_path` and `Trial.local_experiment_path` - We keep existing arguments and properties for backwards compatibility Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: chaowang <[email protected]>

Signed-off-by: chaowang <[email protected]>

…ct#33288) Use SDK commands for all core tests. It is because there was a big regression after migrating to V2 anyscale job runner. Signed-off-by: chaowang <[email protected]>

…treaming execution (ray-project#33406) Signed-off-by: chaowang <[email protected]>

Signed-off-by: Matthew Deng <[email protected]> Signed-off-by: chaowang <[email protected]>

The current node option verification attempts to convert a string key to a dictionary when constructing an error message for blocked options, resulting in unclear / unintended exception. Signed-off-by: dbczumar <[email protected]> Signed-off-by: chaowang <[email protected]>

For long-living, memory leaking actors, it is more desirable to kill oldest task that is leaking the most. This avoid the situation where we constantly kill actor, which may lead to side effects where we generate a lot of log files, or trigger increased memory consumption in gcs / dashboard Co-authored-by: Clarence Ng <[email protected]> Signed-off-by: chaowang <[email protected]>

EBS is not necessary for many nodes test and it's 150GB by default. This reduce it to 30GB. --------- Co-authored-by: Chen Shen <[email protected]> Signed-off-by: chaowang <[email protected]>

Output from compare_perf_metrics: https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0 Signed-off-by: chaowang <[email protected]>

Signed-off-by: chaowang <[email protected]>

CPP generate-bazel-project-template is failing during build, due to extra space in the BUILD.bazel file. This commit fixes that. Signed-off-by: Soumitra Kumar <[email protected]> Signed-off-by: chaowang <[email protected]>

This PR restricts the number of profile events to be sent and aggregates task events from the same task attempt on the worker side to reduce the data sent to GCS. This PR also refactos the metrics tracking to reduce lock contention on the core worker. Signed-off-by: chaowang <[email protected]>

Signed-off-by: chaowang <[email protected]>

…t#32936) Co-authored-by: angelinalg <[email protected]> Co-authored-by: Justin Yu <[email protected]> Co-authored-by: Yunxuan Xiao <[email protected]> Co-authored-by: Yunxuan Xiao <[email protected]> Signed-off-by: chaowang <[email protected]>

Signed-off-by: chaowang <[email protected]>

…dev into cw/component_test_actors

chaowanggg · 2023-04-04T23:31:50Z

@alanwguo @shawnpanda Please review

dashboard/client/src/components/ActorTable.component.test.tsx

alanwguo · 2023-04-06T17:16:19Z

@chaowanggg for the "DCO" failure. You need to make sure to use -s for every git commit you do. Example git commit -s.

This makes it so that you "sign" every commit with your name at the bottom. This is required for the OSS ray repo

dashboard/client/src/components/ActorTable.component.test.tsx

…ent_test_actors

dashboard/client/src/components/ActorTable.component.test.tsx

…#34058) Following with ray-project#33395 (comment), add a component test to improve the code quality Signed-off-by: elliottower <[email protected]>

…#34058) Following with ray-project#33395 (comment), add a component test to improve the code quality Signed-off-by: Jack He <[email protected]>

chaowanggg and others added 30 commits March 20, 2023 21:00

feat

e25340b

Signed-off-by: chaowang <[email protected]>

code review

1c0c451

Signed-off-by: chaowang <[email protected]>

refactor const variables

9341845

Signed-off-by: chaowang <[email protected]>

add util test cases

ee504fb

Signed-off-by: chaowang <[email protected]>

fix

9608cfb

Signed-off-by: chaowang <[email protected]>

lint

7ab6687

Signed-off-by: chaowang <[email protected]>

change to useMemo

7c1d2b8

Signed-off-by: chaowang <[email protected]>

fix

cd9fe35

Signed-off-by: chaowang <[email protected]>

Merge branch 'master' of github.com:chaowanggg/ray-dev into cw/sort_a…

9b86757

…ctor_state

add tests

917c9f5

Signed-off-by: chaowang <[email protected]>

debug

9b7a381

feat

94283fa

Signed-off-by: chaowang <[email protected]>

code review

4fc9665

Signed-off-by: chaowang <[email protected]>

refactor const variables

74aef46

Signed-off-by: chaowang <[email protected]>

add util test cases

b2526f6

Signed-off-by: chaowang <[email protected]>

fix

cdc99d7

Signed-off-by: chaowang <[email protected]>

lint

eefc919

Signed-off-by: chaowang <[email protected]>

change to useMemo

49e268b

Signed-off-by: chaowang <[email protected]>

fix

6d33c08

Signed-off-by: chaowang <[email protected]>

[Dashboard] Add button to download logs to file (ray-project#33337)

ab70669

Signed-off-by: chaowang <[email protected]>

[RLlib] Remove all default config objects and rllib/agents (ray-proje…

e610960

…ct#33242) Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: chaowang <[email protected]>

[core][ci] Fix test_task_events.py (ray-project#33343)

396fb3c

Fix the test run. Signed-off-by: chaowang <[email protected]>

[docs] Reminder to add new methods to the API Ref (ray-project#33389)

1256bbe

Signed-off-by: chaowang <[email protected]>

[Release Test] Remove runtime env usage from release tests (ray-proje…

f5daa34

…ct#33288) Use SDK commands for all core tests. It is because there was a big regression after migrating to V2 anyscale job runner. Signed-off-by: chaowang <[email protected]>

[data] [streaming] Fix inability to pickle Dataset in the middle of s…

f56a93b

…treaming execution (ray-project#33406) Signed-off-by: chaowang <[email protected]>

[ci] Display Core prerelease dependencies (ray-project#33408)

48ce37f

Signed-off-by: Matthew Deng <[email protected]> Signed-off-by: chaowang <[email protected]>

dbczumar and others added 12 commits April 4, 2023 18:24

[nightly] Reduce EBS volume for many nodes tests (ray-project#33432)

12ac2d6

EBS is not necessary for many nodes test and it's 150GB by default. This reduce it to 30GB. --------- Co-authored-by: Chen Shen <[email protected]> Signed-off-by: chaowang <[email protected]>

Release Performance Regression 2.3.0/2.3.1 ray-project#33187

0ab0525

Output from compare_perf_metrics: https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0 Signed-off-by: chaowang <[email protected]>

Fixing lint issue in benchmark_worker_startup (ray-project#33440)

3528a0a

Signed-off-by: chaowang <[email protected]>

[Doc] Workspace template examples (ray-project#32802)

0cfe1fd

Signed-off-by: chaowang <[email protected]>

add tests

a15acbb

Signed-off-by: chaowang <[email protected]>

debug

1d3ca84

Signed-off-by: chaowang <[email protected]>

Merge branch 'cw/component_test_actors' of github.com:chaowanggg/ray-…

a7ff603

…dev into cw/component_test_actors

chaowanggg changed the title ~~Cw/component test actors~~ [Actor] [Code Quality] Add Unit Tests for Actors Sorting Apr 4, 2023

merge

82f0f5c

shawnpanda reviewed Apr 4, 2023

View reviewed changes

chaowanggg added 3 commits April 5, 2023 22:32

review

8e5b7c7

typo

f2cf9a6

const

572b7b7

shawnpanda approved these changes Apr 5, 2023

View reviewed changes

alanwguo reviewed Apr 6, 2023

View reviewed changes

dashboard/client/src/components/ActorTable.component.test.tsx Show resolved Hide resolved

chaowanggg added 2 commits April 6, 2023 22:26

add tests

fe20402

Merge branch 'master' of github.com:chaowanggg/ray-dev into cw/compon…

3591d3b

…ent_test_actors

alanwguo approved these changes Apr 10, 2023

View reviewed changes

dashboard/client/src/components/ActorTable.component.test.tsx Show resolved Hide resolved

dashboard/client/src/components/ActorTable.component.test.tsx Show resolved Hide resolved

chaowanggg added 2 commits April 10, 2023 22:36

fix

a1c1b5a

revert NodeRow

c723b11

rkooo567 merged commit 6db3f1f into ray-project:master Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Actor] [Code Quality] Add Unit Tests for Actors Sorting #34058

[Actor] [Code Quality] Add Unit Tests for Actors Sorting #34058

chaowanggg commented Apr 4, 2023 •

edited

Loading

chaowanggg commented Apr 4, 2023

alanwguo commented Apr 6, 2023

[Actor] [Code Quality] Add Unit Tests for Actors Sorting #34058

[Actor] [Code Quality] Add Unit Tests for Actors Sorting #34058

Conversation

chaowanggg commented Apr 4, 2023 • edited Loading

Why are these changes needed?

Related issue number

Checks

chaowanggg commented Apr 4, 2023

alanwguo commented Apr 6, 2023

chaowanggg commented Apr 4, 2023 •

edited

Loading