Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: navigation manager UI #4936

Merged
merged 67 commits into from
Feb 11, 2019

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Jan 24, 2019

Resolves #4935
Impact: minor
Type: feature

Original work from @ajporlante

Issue

An interface is needed to allow admins to modify the navigation

Solution

Build a navigation editor UI in the Operator 2.0 admin panel

Breaking changes

none

Testing

  1. Add, remove, update navigation items
  2. See changes applied to the storefront using this PR: refactor: navigation data comes from new NavigationTree example-storefront#472

Note. Saving navigation items, and the tree publishes immediately. Discard only discards unsaved changes.

@mikemurray mikemurray self-assigned this Jan 24, 2019
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] feat: navigation manager UI feat: navigation manager UI Feb 6, 2019
@machikoyasuda
Copy link
Contributor

Tested this in Chrome, Safari and Firefox.

Chrome and Safari work great! Firefox doesn't have scroll-linked positioning:
This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!

Testing instructions

  1. Open http://localhost:3000/operator/localization and click 🔁 to reload localized copy
  2. Open http://localhost:3000/operator/navigation
  3. Run reaction-next-starterkit with this branch: refactor: navigation data comes from new NavigationTree example-storefront#472

Flows to test

I tested the following flows:

  1. Edit a name of an nav item -> Check on starter-kit
  2. Edit a url of a nav item -> Check on starter-kit
  3. Edit a non-relative url, like https://socks.com of a nav item -> Check on starter-kit
  4. Check Open in a new tab -> Check on starter-kit
  5. Delete a nav item -> Confirm that a modal shows up -> Check on starter-kit
  6. Drag and drop a nav item -> Check on starter-kit
  7. Create a new nav item, and repeat the steps for that one.

Screenshots

screen shot 2019-02-06 at 3 18 42 pm

  • Editing a nav item:

screen shot 2019-02-06 at 3 26 22 pm

screen shot 2019-02-06 at 3 22 19 pm

  • Dragging/moving a nav item:

screen shot 2019-02-06 at 3 36 29 pm

screen shot 2019-02-06 at 3 36 26 pm

  • Deleting:

screen shot 2019-02-06 at 3 52 33 pm

screen shot 2019-02-06 at 3 52 23 pm

@aldeed
Copy link
Contributor

aldeed commented Feb 8, 2019

@machikoyasuda Now that CI builds are working again, I see only a snyk failure. Is this ready to merge?

@machikoyasuda
Copy link
Contributor

@aldeed Aside from the Snyk errors, this PR is ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants