Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version controlling GLOSSARY #34

Closed
wants to merge 5 commits into from

Conversation

halian-vilela
Copy link
Collaborator

Bringing the GLOSSARY to the repo, as discussed in #14

@cezaraugusto
Copy link
Member

I think this is cool but not sure how it is connected with #14. this seems more like a style guide for authoring docs and not really translating them. am I missing something?

@cezaraugusto cezaraugusto added the needs author response Changes requested needing author's input label Feb 9, 2019
@halian-vilela
Copy link
Collaborator Author

I think this is cool but not sure how it is connected with #14. this seems more like a style guide for authoring docs and not really translating them. am I missing something?

Hey @cezaraugusto

I think the main purpose of this file is let people add their own entries to the glossary and keep discussions about specific terms in the pull requests instead of the little glossary with limited access that lives in #4 now.

For example, in my revisions yesterday I've stumbled upon some terms that I'm pretty sure will have at least 2-3 variations throughout the translation project.

I guess that every time someone finds such terms, they should add it to the glossary and then we try to find a standard term.

@gmsecrieru
Copy link
Member

gmsecrieru commented Feb 9, 2019

Thanks for your help but I believe most of this does not relate to the translation/project.

All MD documents are well structured with examples and following a proper code style. Our goal is to provide a proper PT-BR translation without changing structure, code examples etc.

I've opened #46 in order to keep track of the Glossary terms that were suggested until now in #4 . IMHO we should now aim to feed that file through discussions in separate issues/pull requests. This will make it easier to track each addition and the reasoning behind it.

@halian-vilela
Copy link
Collaborator Author

halian-vilela commented Feb 9, 2019

@cezaraugusto @gmsecrieru

Sorry guys!! This PR came with the wrong text!! The file that went here was the previous version, a wrong copy and paste...

What I wanted to PR was this: https://github.com/halian-vilela/pt-BR.reactjs.glossary

As I stated here I initially thought that we couldn't add .md files, but then the guys suggested that I should add this one to the repo.

I've made some corrections to the text.

I personally think that this structure is better for adding new terms under their own letters.

What do you think?

@halian-vilela halian-vilela mentioned this pull request Feb 9, 2019
@fjoshuajr
Copy link
Collaborator

@cezaraugusto @gmsecrieru

Sorry guys!! This PR came with the wrong text!! The file that went here was the previous version, a wrong copy and paste...

What I wanted to PR was this: halian-vilela/pt-BR.reactjs.glossary

As I stated here I initially thought that we couldn't add .md files, but then the guys suggested that I should add this one to the repo.

I've made some corrections to the text.

I personally think that this structure is better for adding new terms under their own letters.

What do you think?

Glad you fixed the content 👍

But @gmsecrieru has already created a PR (#46) addressing the glossary issue.

@halian-vilela would you mind submitting your changes there?

I'm closing this in favor of #46, just to avoid two PRs addressing the same issue.

@fjoshuajr fjoshuajr closed this Feb 9, 2019
@fjoshuajr fjoshuajr removed needs author response Changes requested needing author's input labels Feb 9, 2019
@halian-vilela
Copy link
Collaborator Author

halian-vilela commented Feb 9, 2019

Solved already. We'll keep the previous format.

@cezaraugusto cezaraugusto added the invalid Something that is outside the scope label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Something that is outside the scope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants