RDART-941: Add support for collections in RealmValue #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
approved these changes
Jan 24, 2024
| /// Extensions on RealmValue providing convenience conversion operators | ||
| extension RealmValueConvenience on RealmValue { | ||
| /// Casts [value] to a List<RealmValue>. It will throw an exception if [value] is not a list. | ||
| RealmList<RealmValue> asList() { |
There was a problem hiding this comment.
We discussed using a getter instead as it is slightly shorter, but it actually goes against https://dart.dev/effective-dart/design#prefer-naming-a-method-as___-if-it-returns-a-different-representation-backed-by-the-original-object, so 👍
|
There's a series of issues I opened for the query engine - not sure if those are legitimate bugs or things are working as designed, so I'll wait to see what @jedelbo comes back with. |
Closed
nirinchev
added a commit
that referenced
this pull request
Mar 6, 2024
* Update to Core next-major * Update old-format file, update changelog * Add support for collections in RealmValue (#1469) * Initial stab at collections in mixed * regenerate ffi bindings * Add more tests * Add notification tests * Return the types * Address some PR feedback * Add RealmValueType * Fix some tests * Add query tests * Add tests for indexOf/contains; add tests for sets * Create a symlink for test data inside tests * Add a few more tests * Correct Core issue link * enable notifications tests * Enable some tests * Re-generate ffi * Fix test * Added a changelog entry * Update Core and reenable some tests * Update core submodule * Move cmake presets to root of repo * Move cmake presets back in realm_dart * Update Core * Fix paths * Regenerate ffi bindings * Remove deprecated members (#1526) * Update changelog * Update paths in prepare-release.yml * [Release 2.0.0-alpha.1] (#1527) * [Release 2.0.0-alpha.1] * fix paths * Read package version from the correct file * More release workflow fixes * .. * Remove some symlink removal * tar the correct packages --------- Co-authored-by: nirinchev <[email protected]> Co-authored-by: Nikola Irinchev <[email protected]> * Fixes to the release process * [Release 2.0.0-alpha.2] (#1528) * [Release 2.0.0-alpha.2] * Remove revived symlink --------- Co-authored-by: nirinchev <[email protected]> Co-authored-by: Nikola Irinchev <[email protected]> * Add support for dynamic.getSet/getMap (#1533) * Add support for dynamic.getSet/getMap * Fix test * More test fixes * Apply suggestions from code review Co-authored-by: Kasper Overgård Nielsen <[email protected]> * Regenerate models * Update changelog --------- Co-authored-by: Kasper Overgård Nielsen <[email protected]> --------- Co-authored-by: Realm CI <[email protected]> Co-authored-by: nirinchev <[email protected]> Co-authored-by: Kasper Overgård Nielsen <[email protected]>
nirinchev
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1505
Fixes #1504
TODO:
results/list.indexOf/containsConsider moving RealmList/Map to common. Right nowImplemented as extensions inside the realm package..asList/.asMapreturns the dart list/map, but that doesn't have the extra information RealmList/RealmMap has.Set<RealmValue>behavior@type = $0query tests when Allow query substitution for the @type argument realm-core#7289 is addressed.