Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next-major #1519

Merged
merged 23 commits into from
Mar 6, 2024
Merged

next-major #1519

merged 23 commits into from
Mar 6, 2024

Conversation

nirinchev
Copy link
Member

No description provided.

* Initial stab at collections in mixed

* regenerate ffi bindings

* Add more tests

* Add notification tests

* Return the types

* Address some PR feedback

* Add RealmValueType

* Fix some tests

* Add query tests

* Add tests for indexOf/contains; add tests for sets

* Create a symlink for test data inside tests

* Add a few more tests

* Correct Core issue link

* enable notifications tests

* Enable some tests

* Re-generate ffi

* Fix test

* Added a changelog entry
Copy link

coveralls-official bot commented Feb 8, 2024

Pull Request Test Coverage Report for Build 8146722419

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 144 of 167 (86.23%) changed or added relevant lines in 8 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+2.3%) to 89.735%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/realm_dart/lib/src/map.dart 14 16 87.5%
packages/realm_dart/lib/src/results.dart 3 5 60.0%
packages/realm_dart/lib/src/list.dart 15 19 78.95%
packages/realm_dart/lib/src/realm_object.dart 14 19 73.68%
packages/realm_dart/lib/src/native/realm_core.dart 76 86 88.37%
Files with Coverage Reduction New Missed Lines %
packages/realm_dart/lib/src/realm_object.dart 1 86.35%
packages/realm_dart/lib/src/results.dart 1 93.23%
packages/realm_dart/lib/src/set.dart 1 85.0%
packages/realm_dart/lib/src/subscription.dart 1 90.91%
Totals Coverage Status
Change from base Build 8095999598: 2.3%
Covered Lines: 3829
Relevant Lines: 4267

💛 - Coveralls

* main:
  Use github hosted M1 runners (#1520)
* ni/cmake-presets:
  Move cmake presets to root of repo
}

realm.write(() {
realm.add(Container(anything: RealmValue.from([1, 'foo', 3.14])));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can do add(Container(anything: RealmValue.from(json))); ?? @nirinchev

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on what json is - if it's string, we won't deserialize it and construct an object graph from it, but if it's a map, then yes.

nirinchev and others added 13 commits February 23, 2024 14:41
* main:
  Use PartBuilder instead of SharedPartBuilder (#1310)
* [Release 2.0.0-alpha.1]

* fix paths

* Read package version from the correct file

* More release workflow fixes

* ..

* Remove some symlink removal

* tar the correct packages

---------

Co-authored-by: nirinchev <[email protected]>
Co-authored-by: Nikola Irinchev <[email protected]>
* [Release 2.0.0-alpha.2]

* Remove revived symlink

---------

Co-authored-by: nirinchev <[email protected]>
Co-authored-by: Nikola Irinchev <[email protected]>
* Add support for dynamic.getSet/getMap

* Fix test

* More test fixes

* Apply suggestions from code review

Co-authored-by: Kasper Overgård Nielsen <[email protected]>

* Regenerate models

* Update changelog

---------

Co-authored-by: Kasper Overgård Nielsen <[email protected]>
@nirinchev nirinchev merged commit 4432c3e into main Mar 6, 2024
54 of 55 checks passed
@nirinchev nirinchev deleted the next-major branch March 6, 2024 12:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants