RDART-824 RDART-825 Add support for dynamic.getSet/getMap #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
force-pushed
the
ni/dynamic-collections
branch
from
28a8e16
to
7482829
Compare
nielsenko
approved these changes
Mar 1, 2024
Comment on lines
201
to
211
| if (setMetadata != null && _isTypeGenericObject<T>()) { | ||
| switch (setMetadata.schema.baseType) { | ||
| case ObjectType.realmObject: | ||
| return object.realm.createSet<RealmObject>(handle, setMetadata); | ||
| case ObjectType.embeddedObject: | ||
| return object.realm.createSet<EmbeddedObject>(handle, setMetadata); | ||
| case ObjectType.asymmetricObject: | ||
| return object.realm.createSet<AsymmetricObject>(handle, setMetadata); | ||
| default: | ||
| throw RealmError('List of ${setMetadata.schema.baseType} is not supported yet'); | ||
| } |
There was a problem hiding this comment.
This rubs me the wrong way, but I get the point..
| throws<RealmException>( | ||
| "Property 'strings' on class 'AllCollections' is 'RealmCollectionType.list' but the method used to access it expected 'RealmCollectionType.none'.")); | ||
| "Property 'stringList' on class 'AllCollections' is 'RealmCollectionType.list' but the method used to access it expected 'RealmCollectionType.none'.")); |
There was a problem hiding this comment.
I hope we can give a better error message at some point, instead of leaking the internal representation stuff.
Co-authored-by: Kasper Overgård Nielsen <[email protected]>
nirinchev
changed the title
This was referenced Mar 4, 2024
Closed
nirinchev
added a commit
that referenced
this pull request
Mar 6, 2024
* Update to Core next-major * Update old-format file, update changelog * Add support for collections in RealmValue (#1469) * Initial stab at collections in mixed * regenerate ffi bindings * Add more tests * Add notification tests * Return the types * Address some PR feedback * Add RealmValueType * Fix some tests * Add query tests * Add tests for indexOf/contains; add tests for sets * Create a symlink for test data inside tests * Add a few more tests * Correct Core issue link * enable notifications tests * Enable some tests * Re-generate ffi * Fix test * Added a changelog entry * Update Core and reenable some tests * Update core submodule * Move cmake presets to root of repo * Move cmake presets back in realm_dart * Update Core * Fix paths * Regenerate ffi bindings * Remove deprecated members (#1526) * Update changelog * Update paths in prepare-release.yml * [Release 2.0.0-alpha.1] (#1527) * [Release 2.0.0-alpha.1] * fix paths * Read package version from the correct file * More release workflow fixes * .. * Remove some symlink removal * tar the correct packages --------- Co-authored-by: nirinchev <[email protected]> Co-authored-by: Nikola Irinchev <[email protected]> * Fixes to the release process * [Release 2.0.0-alpha.2] (#1528) * [Release 2.0.0-alpha.2] * Remove revived symlink --------- Co-authored-by: nirinchev <[email protected]> Co-authored-by: Nikola Irinchev <[email protected]> * Add support for dynamic.getSet/getMap (#1533) * Add support for dynamic.getSet/getMap * Fix test * More test fixes * Apply suggestions from code review Co-authored-by: Kasper Overgård Nielsen <[email protected]> * Regenerate models * Update changelog --------- Co-authored-by: Kasper Overgård Nielsen <[email protected]> --------- Co-authored-by: Realm CI <[email protected]> Co-authored-by: nirinchev <[email protected]> Co-authored-by: Kasper Overgård Nielsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1305
Fixes #1324
Fixes #1323