Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jan 11, 2023

This is removed in Kubernetes 1.22
https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added cherry-pick release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Jan 11, 2023
@pmacik pmacik changed the title Remove v1beta1 CRD (#1300) cherry-pick(release-v1.3.x): Remove v1beta1 CRD Jan 11, 2023
@pmacik pmacik added this to the 1.3.3 milestone Jan 11, 2023
@pmacik
Copy link
Contributor Author

pmacik commented Jan 11, 2023

Depends on #1359

@pmacik pmacik force-pushed the cherry-pick_release-v1.3.x_6cb409ed_593cfe67-bda8-42a4-9bc9-8b369af1afc1 branch from 95ece5a to e8c8711 Compare January 11, 2023 14:46
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1358 (e8c8711) into release-v1.3.x (7b05b8c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.3.x    #1358   +/-   ##
===============================================
  Coverage           58.06%   58.06%           
===============================================
  Files                  33       33           
  Lines                2797     2797           
===============================================
  Hits                 1624     1624           
  Misses               1018     1018           
  Partials              155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b05b8c...e8c8711. Read the comment docs.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7614578 into redhat-developer:release-v1.3.x Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants