Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[In progress] Updating kinematic: ini files #20

Closed
wants to merge 12 commits into from

Conversation

rsantos88
Copy link
Contributor

Updating kinematic: ini files

@rsantos88 rsantos88 requested a review from jgvictores May 6, 2019 10:27
@rsantos88 rsantos88 self-assigned this May 6, 2019
@rsantos88 rsantos88 changed the title Updating kinematic: ini files [In progress] Updating kinematic: ini files May 6, 2019
@jgvictores
Copy link
Member

@rsantos88 How about removing old/unused/useless?

@jgvictores
Copy link
Member

@rsantos88 How about removing old/unused/useless?

PS: Yes, this was proposed at #7

link_3 (offset 0.0) (D 0.0 ) (A 0.0 ) (alpha 90.0) (mass 0 ) (cog 0 0 0) (inertia 0 0 0)
link_4 (offset 0.0) (D -0.202 ) (A 0.0 ) (alpha -90.0) (mass 2.396 ) (cog 0 0 0) (inertia 0 0 0)
link_5 (offset -90.0) (D 0.0 ) (A -0.09 ) (alpha 0.0) (mass 0.300 ) (cog 0 0 0) (inertia 0 0 0)
link_6 (offset -90.0) (D 0.0 ) (A 0.0 ) (alpha 90.0)
Copy link
Member

@jgvictores jgvictores May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link_5 and link_6 redundant with HN

link_3 (offset 0.0) (D 0.0 ) (A 0.0 ) (alpha 90.0) (mass 0 ) (cog 0 0 0) (inertia 0 0 0)
link_4 (offset 0.0) (D -0.202 ) (A 0.0 ) (alpha -90.0) (mass 2.396 ) (cog 0 0 0) (inertia 0 0 0)
link_5 (offset -90.0) (D 0.0 ) (A -0.09 ) (alpha 0.0) (mass 0.300 ) (cog 0 0 0) (inertia 0 0 0)
link_6 (offset -90.0) (D 0.0 ) (A 0.0 ) (alpha 90.0)
Copy link
Member

@jgvictores jgvictores May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link_5 and link_6 redundant with HN

@rsantos88
Copy link
Contributor Author

rsantos88 commented May 7, 2019

It's already done but, I'll close this PR and reopen a new PR with less changes

@rsantos88 rsantos88 closed this May 7, 2019
@rsantos88 rsantos88 deleted the test-update-kinematic branch May 7, 2019 13:24
@jgvictores
Copy link
Member

Closed as invalid in favor of #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants