Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_formatter): Comments #3227

Merged
merged 15 commits into from
Sep 22, 2022
Merged

refactor(rome_formatter): Comments #3227

merged 15 commits into from
Sep 22, 2022

Commits on Sep 22, 2022

  1. Empty File to create placeholder PR

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    7ff14a9 View commit details
    Browse the repository at this point in the history

  2. Empty File to create placeholder PR

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    9977d28 View commit details
    Browse the repository at this point in the history

  3. feat(rome_formatter): Comments multi map (#3230)

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    8c0ee68 View commit details
    Browse the repository at this point in the history

  4. Comments infrastructure

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f9a0398 View commit details
    Browse the repository at this point in the history

  5. Document Comments API

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    39abce7 View commit details
    Browse the repository at this point in the history

  6. refactor(rome_formatter): Delete FormatElement::Comment 

    This PR removes the `FormatElement::Comment` element. It was used to this point because the `group` builder had to move `comments` outside of the start/end of the group.

No such inspection is necessary after the refactor which is why the element can be deleted.
    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    884e258 View commit details
    Browse the repository at this point in the history

  7. refactor(rome_formatter): Move verbatim formatting to rome_formatter 

    This PR moves the logic for formatting a node as `verbatim` to `rome_formatter` as it isn't JS specific
    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a9f9ef4 View commit details
    Browse the repository at this point in the history

  8. Rename cst back to token 

    Comments Formatter integration
    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    fb3e2a9 View commit details
    Browse the repository at this point in the history

  9. Documentation and naming

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    ba0fb8b View commit details
    Browse the repository at this point in the history

  10. Update crates/rome_formatter/src/comments.rs 

    Co-authored-by: l3ops <[email protected]>
    @MichaReiser @leops
    MichaReiser and leops committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    eae6f8b View commit details
    Browse the repository at this point in the history

  11. Rename soft_line_indent_or_spaced to soft_space_or_block_indent

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f42e894 View commit details
    Browse the repository at this point in the history

  12. refactor(rome_js_formatter): Part 6: JS Comments formatting

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    0abbbb6 View commit details
    Browse the repository at this point in the history

  13. Documentation

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    7581c1d View commit details
    Browse the repository at this point in the history

  14. refactor(rome_js_formatter): Part 7: Use comments API in JS node form… 

    …atters (#3245)
    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    74147a3 View commit details
    Browse the repository at this point in the history

  15. chore(xtask): Part 8: Add line breaks before doc comments (#3246)

    @MichaReiser
    MichaReiser committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    6a430dc View commit details
    Browse the repository at this point in the history