Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not setup qos override option with QoSPolicyKind.DEADLINE #1047

Closed
maghauke opened this issue Nov 28, 2022 · 2 comments
Closed

Can not setup qos override option with QoSPolicyKind.DEADLINE #1047

maghauke opened this issue Nov 28, 2022 · 2 comments
Assignees
@fujitatomoya
Labels
bug Something isn't working

Comments

@maghauke
Copy link

Bug report

Expected behavior

I try to set up a qos override option for my subscriber using:

qos_override_opts = QosOverride.QoSOverridingOptions(
            policy_kinds=(
                Qos.QoSPolicyKind.HISTORY,
                Qos.QoSPolicyKind.DEPTH,
                Qos.QoSPolicyKind.RELIABILITY,
                Qos.QoSPolicyKind.DEADLINE,
                )
        )

Actual behavior

When launching the relevant nodes subscriber I get the following error message:

File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/qos_overriding_options.py", line 165, in _get_qos_policy_parameter
value = value.nanoseconds()
TypeError: 'int' object is not callable

To me it seems like: this
does not return a Duration object but only an int...
@fujitatomoya fujitatomoya self-assigned this Dec 1, 2022
@fujitatomoya fujitatomoya added the bug Something isn't working label Dec 1, 2022
fujitatomoya added a commit to fujitatomoya/ros2_test_prover that referenced this issue Dec 1, 2022
@fujitatomoya
Can not setup qos override option with QoSPolicyKind.DEADLINE
63b3c1e 
  ros2/rclpy#1047

Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit to fujitatomoya/rclpy that referenced this issue Dec 2, 2022
@fujitatomoya
decorator should not be callable.
ec580f8 
  ros2#1047

Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya fujitatomoya mentioned this issue Dec 2, 2022
Merged
@fujitatomoya
Copy link
Collaborator

@maghauke thanks for posting issue. this can be fixed with #1050.

adityapande-1995 pushed a commit that referenced this issue Dec 2, 2022
@fujitatomoya
decorator should not be callable. (#1050)
2da35a4 
#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
mergify bot pushed a commit that referenced this issue Dec 2, 2022
@fujitatomoya @mergify
decorator should not be callable. (#1050)
bbfa36d 
#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)
fujitatomoya added a commit that referenced this issue Dec 22, 2022
@mergify @fujitatomoya
decorator should not be callable. (#1050) (#1051)
6b6617a 
#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)

Co-authored-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator

#1050 has been completed including backport of humble, closing this issue.

iuhilnehc-ynos pushed a commit to iuhilnehc-ynos/rclpy that referenced this issue Apr 10, 2023
@mergify @fujitatomoya
decorator should not be callable. (ros2#1050) (ros2#1051)
244ff90 
ros2#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
iuhilnehc-ynos pushed a commit to iuhilnehc-ynos/rclpy that referenced this issue Apr 10, 2023
@mergify @fujitatomoya
decorator should not be callable. (ros2#1050) (ros2#1051)
7dca753 
ros2#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
iuhilnehc-ynos pushed a commit to iuhilnehc-ynos/rclpy that referenced this issue Apr 10, 2023
@mergify @fujitatomoya
decorator should not be callable. (ros2#1050) (ros2#1051)
6287783 
ros2#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Barry-Xu-2018 pushed a commit to Barry-Xu-2018/rclpy that referenced this issue Apr 10, 2023
@mergify @fujitatomoya @Barry-Xu-2018
decorator should not be callable. (ros2#1050) (ros2#1051)
712522e 
ros2#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Barry Xu <[email protected]>
fujitatomoya added a commit that referenced this issue Apr 12, 2023
@Barry-Xu-2018 @mergify
@Flova @fujitatomoya @audrow @Crola1702 @Achllle
Rebase humble/pr-1033 (#1107)
1fa2d19 
* Add parallel callback test (#1044) (#1052)

* Add parallel callback test
Signed-off-by: Florian Vahl <[email protected]>
(cherry picked from commit 40054ba)

Co-authored-by: Florian Vahl <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* decorator should not be callable. (#1050) (#1051)

#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* 3.3.6

Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066)

Co-authored-by: Cristóbal Arroyo <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* 3.3.7

Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088)

* Fix #983 by saving future and checking for + raising any exceptions

Signed-off-by: Achille Verheye <[email protected]>
Co-authored-by: Achille Verheye <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* Deal with ParameterUninitializedException for parameter service (#1033)

* Deal with ParameterUninitializedException for parameter service

Signed-off-by: Barry Xu <[email protected]>

* Enable all tests in test_parameter_client.py

Signed-off-by: Barry Xu <[email protected]>

* Get empty value for ParameterUninitializedException

Signed-off-by: Barry Xu <[email protected]>

Signed-off-by: Barry Xu <[email protected]>
(cherry picked from commit e442ad2)

# Conflicts:
#	rclpy/test/test_parameter_client.py
Signed-off-by: Barry Xu <[email protected]>

* Fix conflict and use new testcase (#1053)

Signed-off-by: Barry Xu <[email protected]>

* Changed for filename with alphabet order

Signed-off-by: Barry Xu <[email protected]>

---------

Signed-off-by: Barry Xu <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Achille Verheye <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Florian Vahl <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Audrow Nash <[email protected]>
Co-authored-by: Cristóbal Arroyo <[email protected]>
Co-authored-by: Achille Verheye <[email protected]>
fujitatomoya added a commit that referenced this issue Apr 21, 2023
@Barry-Xu-2018 @mergify
@Flova @fujitatomoya @audrow @Crola1702 @Achllle
Rebase humble/pr-1033 (#1107)
729ebee 
* Add parallel callback test (#1044) (#1052)

* Add parallel callback test
Signed-off-by: Florian Vahl <[email protected]>
(cherry picked from commit 40054ba)

Co-authored-by: Florian Vahl <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* decorator should not be callable. (#1050) (#1051)

#1047

Signed-off-by: Tomoya Fujita <[email protected]>

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2da35a4)

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* 3.3.6

Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066)

Co-authored-by: Cristóbal Arroyo <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* 3.3.7

Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088)

* Fix #983 by saving future and checking for + raising any exceptions

Signed-off-by: Achille Verheye <[email protected]>
Co-authored-by: Achille Verheye <[email protected]>
Signed-off-by: Barry Xu <[email protected]>

* Deal with ParameterUninitializedException for parameter service (#1033)

* Deal with ParameterUninitializedException for parameter service

Signed-off-by: Barry Xu <[email protected]>

* Enable all tests in test_parameter_client.py

Signed-off-by: Barry Xu <[email protected]>

* Get empty value for ParameterUninitializedException

Signed-off-by: Barry Xu <[email protected]>

Signed-off-by: Barry Xu <[email protected]>
(cherry picked from commit e442ad2)

# Conflicts:
#	rclpy/test/test_parameter_client.py
Signed-off-by: Barry Xu <[email protected]>

* Fix conflict and use new testcase (#1053)

Signed-off-by: Barry Xu <[email protected]>

* Changed for filename with alphabet order

Signed-off-by: Barry Xu <[email protected]>

---------

Signed-off-by: Barry Xu <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Achille Verheye <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Florian Vahl <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Audrow Nash <[email protected]>
Co-authored-by: Cristóbal Arroyo <[email protected]>
Co-authored-by: Achille Verheye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fujitatomoya fujitatomoya

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fujitatomoya @maghauke