-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with ParameterUninitializedException for parameter service #1033
Deal with ParameterUninitializedException for parameter service #1033
Conversation
Signed-off-by: Barry Xu <[email protected]>
32a3792
to
9466d1d
Compare
Signed-off-by: Barry Xu <[email protected]>
Not sure why test_parameter_client.py isn't included in CMakeLists.txt. |
@Barry-Xu-2018 since this is draft, are you still working on this? |
Yes. |
Signed-off-by: Barry Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ivanpauno can you take a look at this too? it is the same change for ros2/rclcpp#2036 |
About Linux failure, the cause seems to be related to CI environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Given the crashing behavior, will this be backported to the currently supported Humble & Galactic? |
@Mergifyio backport humble galactic foxy |
* Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py
* Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py
* Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/CMakeLists.txt # rclpy/rclpy/parameter_service.py # rclpy/test/test_parameter_client.py
✅ Backports have been created
|
…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py
…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Chen Lihui <[email protected]>
…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Chen Lihui <[email protected]>
…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Chen Lihui <[email protected]>
…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <[email protected]>
…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <[email protected]>
* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <[email protected]> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <[email protected]> Signed-off-by: Barry Xu <[email protected]> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.6 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.7 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <[email protected]> * Changed for filename with alphabet order Signed-off-by: Barry Xu <[email protected]> --------- Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Audrow Nash <[email protected]> Co-authored-by: Cristóbal Arroyo <[email protected]> Co-authored-by: Achille Verheye <[email protected]>
* Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py
* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <[email protected]> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <[email protected]> Signed-off-by: Barry Xu <[email protected]> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.6 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.7 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <[email protected]> * Changed for filename with alphabet order Signed-off-by: Barry Xu <[email protected]> --------- Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Audrow Nash <[email protected]> Co-authored-by: Cristóbal Arroyo <[email protected]> Co-authored-by: Achille Verheye <[email protected]>
…port #1033) (#1041) Signed-off-by: Barry Xu <[email protected]>
Address #1030