Fix #983 by saving future and checking for + raising any exceptions (… #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (ros2#1073) * Fix ros2#983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
|
replacement of #1087. @adityapande-1995 @clalancette i think this would be better to backport to humble, regression test is already in humble too. see #1052 |
|
CI:
|
|
https://build.ros2.org/job/Hpr__rclpy__ubuntu_jammy_amd64/18/ are known as flaky tests, i will go ahead to merge this. |
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
…ns (ros2#1073) (ros2#1088) * Fix ros2#983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Chen Lihui <[email protected]>
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
…ns (ros2#1073) (ros2#1088) * Fix ros2#983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Chen Lihui <[email protected]>
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
…ns (ros2#1073) (ros2#1088) * Fix ros2#983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Chen Lihui <[email protected]>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclpy
that referenced
this pull request
Apr 10, 2023
…ns (ros2#1073) (ros2#1088) * Fix ros2#983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Barry Xu <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Apr 12, 2023
* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <[email protected]> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <[email protected]> Signed-off-by: Barry Xu <[email protected]> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.6 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.7 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <[email protected]> * Changed for filename with alphabet order Signed-off-by: Barry Xu <[email protected]> --------- Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Audrow Nash <[email protected]> Co-authored-by: Cristóbal Arroyo <[email protected]> Co-authored-by: Achille Verheye <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Apr 21, 2023
* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <[email protected]> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <[email protected]> Signed-off-by: Barry Xu <[email protected]> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.6 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <[email protected]> Signed-off-by: Barry Xu <[email protected]> * 3.3.7 Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: Achille Verheye <[email protected]> Signed-off-by: Barry Xu <[email protected]> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <[email protected]> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Barry Xu <[email protected]> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <[email protected]> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <[email protected]> * Changed for filename with alphabet order Signed-off-by: Barry Xu <[email protected]> --------- Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Audrow Nash <[email protected]> Signed-off-by: Achille Verheye <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Audrow Nash <[email protected]> Co-authored-by: Cristóbal Arroyo <[email protected]> Co-authored-by: Achille Verheye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#1073)