Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master -> rskip351+rskip144 merge #2755

Merged
merged 99 commits into from
Sep 26, 2024

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    2031de7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    760908a View commit details
    Browse the repository at this point in the history
  3. Updated structure

    asoto-iov committed May 23, 2024
    Configuration menu
    Copy the full SHA
    db7750c View commit details
    Browse the repository at this point in the history
  4. Adding tests

    asoto-iov committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3bc0a57 View commit details
    Browse the repository at this point in the history
  5. fixing sonar issue

    asoto-iov committed May 23, 2024
    Configuration menu
    Copy the full SHA
    bf975c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    923447f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    3dab053 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge pull request #2454 from rsksmart/juraj/eth_call_stableGasPrice_…

    …multi_factory
    
    feat(smgp): implements eth_call exchange rate provider
    Vovchyk authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f7a212e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39d0e26 View commit details
    Browse the repository at this point in the history
  3. Updating tests

    asoto-iov committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    26fa303 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    6b10626 View commit details
    Browse the repository at this point in the history
  2. fix test

    asoto-iov committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4d5e1d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    002510e View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge pull request #2455 from rsksmart/adding_web_provider

    Adding new Web Provider
    Vovchyk authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    087e6a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3118a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    fdf71ad View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    08c7e9a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    9c5f722 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    e360b7e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2598 from rsksmart/vovchyk/stablemingasprice-ref

    feat(stableMinGasPrice): refactoring
    Vovchyk authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    144e718 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    30a0ee8 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Configuration menu
    Copy the full SHA
    1d9c713 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. addressing comments

    rmoreliovlabs committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    afadadb View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    20ef32d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Initial constants and config for the max initcode size

    In order to implement the verification of initcode size, necessary for the RSKIP438,
    we need the constant value with the max allowed value. So we can start to validate
    and use it on the logic of the verification
    fmacleal committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f5da98a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Addressing comments

    rmoreliovlabs committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c37c4d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Adding back the pull_request trigger

    In order to have the RIT tests working as we have it today, we need to add triggers for
    every commit and for when the PR is opened, but only for masters and *-rc branches base branches.
    fmacleal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a775973 View commit details
    Browse the repository at this point in the history
  2. Feature/initcode size limit using transaction creations (#2665)

    * Initial constants and config for the max initcode size
    
    In order to implement the verification of initcode size, necessary for the RSKIP438,
    we need the constant value with the max allowed value. So we can start to validate
    and use it on the logic of the verification
    
    - Adding scenarios of test for the contract creation with DSL
    - The validation for the initCode size test was added
    - The validation is based on the RSKIP that enables it
    - Validation added for the contractCreation during transaction execution
    
    Finished the implementation of transactionCost and initcode size validation
    
    - All the logic related with transaction cost was changed to meet the new cost criteria
    - More tests were added to be sure that the flow is following the RSKIP438
    - Tests were added to validate that this cost and validation doesn't impact before reach the activation height
    
    Applied some suggestions from review
    
    Adding tests to validate the failure if we don't have enough gas to cover initCode
    
    * Refactor from the Initcode cost calculation
    
    In order to have the exact same logic for the initcode cost calculation,
    we introduced some new classes that can be easily reused by the TransactionExecutor and VM classes. This way, if this logic change, we won't have to change the code in multiple places.
    
    It was also introduced an interface for it, so we can expand this idea and
    in the future, be able to calculate total transactions just calling a method
    to calculate it independent of the logic used.
    
    * Applying some more suggestions from review
    
    Co-Authored-By: Nazaret García Revetria <[email protected]>
    Co-Authored-By: Vovchyk <[email protected]>
    3 people committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6a0e6e1 View commit details
    Browse the repository at this point in the history
  3. Feature/initcode size limit using transaction creations (#2665)

    * Initial constants and config for the max initcode size
    
    In order to implement the verification of initcode size, necessary for the RSKIP438,
    we need the constant value with the max allowed value. So we can start to validate
    and use it on the logic of the verification
    
    - Adding scenarios of test for the contract creation with DSL
    - The validation for the initCode size test was added
    - The validation is based on the RSKIP that enables it
    - Validation added for the contractCreation during transaction execution
    
    Finished the implementation of transactionCost and initcode size validation
    
    - All the logic related with transaction cost was changed to meet the new cost criteria
    - More tests were added to be sure that the flow is following the RSKIP438
    - Tests were added to validate that this cost and validation doesn't impact before reach the activation height
    
    Applied some suggestions from review
    
    Adding tests to validate the failure if we don't have enough gas to cover initCode
    
    * Refactor from the Initcode cost calculation
    
    In order to have the exact same logic for the initcode cost calculation,
    we introduced some new classes that can be easily reused by the TransactionExecutor and VM classes. This way, if this logic change, we won't have to change the code in multiple places.
    
    It was also introduced an interface for it, so we can expand this idea and
    in the future, be able to calculate total transactions just calling a method
    to calculate it independent of the logic used.
    
    * Applying some more suggestions from review
    
    Co-Authored-By: Nazaret García Revetria <[email protected]>
    Co-Authored-By: Vovchyk <[email protected]>
    3 people committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b40289d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'feature/introduce_initcode_size_limit' of github.com:rs…

    …ksmart/rskj into feature/introduce_initcode_size_limit
    fmacleal committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    acaca32 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    2734e18 View commit details
    Browse the repository at this point in the history
  2. Update rit.yml

    Using the default branch set on the inputs from workflow dispatch would be a better re-use.
    fmacleal authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c42b470 View commit details
    Browse the repository at this point in the history
  3. Revert "Update rit.yml"

    This reverts commit c42b470.
    fmacleal committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5e2f1d2 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2701 from rsksmart/feature/add_rootstock_integrat…

    …ion_tests_workflow
    
    Adding Rootstock Integration Tests workflow
    Vovchyk authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a1e21dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a274c63 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fba3cf3 View commit details
    Browse the repository at this point in the history
  7. Rename variables in tests

    marcos-iov committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    dde9970 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5bb11d5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8a3d673 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b5a255f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bba81f7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e24caf0 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    06e5046 View commit details
    Browse the repository at this point in the history
  14. Rename variables in tests

    marcos-iov committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8548a31 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f8816af View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    eaed340 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3878e19 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    18a0abd View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    fe972e5 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6ab44a6 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    5c7b1a1 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    4fbdf69 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge pull request #2722 from rsksmart/master

    master -> feature/include_stable_minGasPrice_provider merge
    Vovchyk authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f8fbcaa View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2706 from rsksmart/refactor-tests

    Refactor Bridge related tests
    josedahlquist authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    128bcdb View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Create flyover redeem script builder

    Remove unused import
    
    Remove mistaken reason
    
    Minor refactor
    
    Make flyover rs builder receive a keccak256 hash instead of sha256 one
    
    Refactors
    julia-zack authored and marcos-iov committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8e0604a View commit details
    Browse the repository at this point in the history
  2. Delete FlyoverRedeemScriptCreationException and move flyover reason t…

    …o RedeemScriptCreationException
    julia-zack authored and marcos-iov committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0e71532 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e90a050 View commit details
    Browse the repository at this point in the history
  4. Add @OverRide annotation

    marcos-iov committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2be66e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    b0d9fe5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17b20ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    78a6dc0 View commit details
    Browse the repository at this point in the history
  4. Fixing some issues on RIT workflow

    Issues fixed:
    1 - Remove the trigger on push for master  and *-rc -> we don't need that
    anymore since we are running it for every commit on PRs against these branches.
    
    2 - Solve the issue that the status of an execution triggered via workflow doesn't update the PR status.
     And if we need to use a different branch for RIT, Powpeg and RIT in the PR, it won't change the status to
     green after the workflow_dispatch execution -> We will do that adding a parsing on the description, looking
     for the branch that need to be used for that PR. If there is no branch configured on the description, we will
     try to use the default one.
    fmacleal committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    870d0e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    7719ed1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08b28eb View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2727 from rsksmart/flyover-rs-parser

    Create a flyover redeem script builder
    josedahlquist authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0994382 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    1bf9d53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1265ac9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8cecf43 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eede703 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a4f2040 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0da5905 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2310 from rsksmart/feature/include_stable_minGasP…

    …rice_provider
    
    Configurable Fiat-Based Stable MinGasPrice
    Vovchyk authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7dd58c6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a8fc652 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1680ad6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4f4b5e6 View commit details
    Browse the repository at this point in the history
  11. Update .github/workflows/rit.yml

    Co-authored-by: Lucas <[email protected]>
    fmacleal and lucasvuotto authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4c3a2c3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ce40c21 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #2627 from rsksmart/feature/introduce_initcode_siz…

    …e_limit
    
    Initial constants and config for the max initcode size
    Vovchyk authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6fe81bb View commit details
    Browse the repository at this point in the history
  14. Update .github/workflows/rit.yml

    Co-authored-by: Lucas <[email protected]>
    fmacleal and lucasvuotto authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    db418ac View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Update .github/workflows/rit.yml

    Co-authored-by: Lucas <[email protected]>
    fmacleal and lucasvuotto authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0c7ab7e View commit details
    Browse the repository at this point in the history
  2. Update .github/workflows/rit.yml

    Co-authored-by: Lucas <[email protected]>
    fmacleal and lucasvuotto committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9c97b9d View commit details
    Browse the repository at this point in the history
  3. Update .github/workflows/rit.yml

    Co-authored-by: Lucas <[email protected]>
    fmacleal and lucasvuotto authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    eddbb9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f74d14c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    0d91f89 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    ab6bbd0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2724 from rsksmart/fix/solving_issues_rit_workflow

    Fixing some issues on RIT workflow
    Vovchyk authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6c970ff View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    4c372ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    642406b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2744 from rsksmart/vovchyk/initcode-limit-feature…

    …-fix
    
    fix(MaxInitcodeSize): fix NPE in transactionCost() method
    Vovchyk authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    29408dc View commit details
    Browse the repository at this point in the history
  4. build: bump jackson version

    Vovchyk committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4e1b870 View commit details
    Browse the repository at this point in the history
  5. refactor: improve logging

    Vovchyk committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e0cb416 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a808164 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2715 from rsksmart/vovchyk/jackson-ver-bump

    build: bump jackson version
    Vovchyk authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d27c6b9 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #2624 from rsksmart/vovchyk/min-java-ver-bump

    chore: increase min supported java version to 17
    Vovchyk authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    87d4895 View commit details
    Browse the repository at this point in the history
  9. chore: add java21 support

    Vovchyk committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    325020d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2cc5bef View commit details
    Browse the repository at this point in the history
  11. Merge pull request #2640 from rsksmart/vovchyk/java21-support

    chore: add java21 support
    Vovchyk authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2a0d333 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3059c4c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    ecbb0ad View commit details
    Browse the repository at this point in the history