Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #33005

Merged
merged 28 commits into from
Apr 16, 2016
Merged

Rollup of 11 pull requests #33005

merged 28 commits into from
Apr 16, 2016

Commits on Apr 13, 2016

  1. Configuration menu
    Copy the full SHA
    5a8bbf1 View commit details
    Browse the repository at this point in the history
  2. Add regression test

    jseyfried committed Apr 13, 2016
    Configuration menu
    Copy the full SHA
    f08f75f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    340eff6 View commit details
    Browse the repository at this point in the history
  4. Doc fix: Update Cargo.toml in book/getting-started

    The Cargo.toml mentioned in book/getting-started
    is missing the section called `[dependencies]`
    deepak committed Apr 13, 2016
    Configuration menu
    Copy the full SHA
    722faa0 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2016

  1. Configuration menu
    Copy the full SHA
    974f1ef View commit details
    Browse the repository at this point in the history
  2. rustbuild: Improve error messaging in bootstrap.py

    For normal invocations, print a short error message and exit. When
    the verbose option is enabled, also print the backtrace.
    caipre committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    ffff91a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e0f997d View commit details
    Browse the repository at this point in the history
  4. implement RFC amendment 1494

    durka committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    01aebf0 View commit details
    Browse the repository at this point in the history
  5. Delegate whether to print docblocks to 'document'

    Add test to check this resolves rust-lang#24838 and rust-lang#26871.
    pierzchalski committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    d8d8669 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cd85120 View commit details
    Browse the repository at this point in the history
  7. doc: add missing comma

    tshepang committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    571607f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    37e59b9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f916491 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2016

  1. Configuration menu
    Copy the full SHA
    ca1d29c View commit details
    Browse the repository at this point in the history
  2. Add tests against weird provided/required method behaviour

    In `test/rustdoc/manual_impl.rs` there are now three structs:
    
    * S1 implements and documents required method `a_method`.
    * S2 implements and documents `a_method` as well as provided
      method `b_method`.
    * S3 implements `a_method` and `b_method`, but only documents
      `b_method`.
    
    For a struct, we want the rendered trait impls to include documentation
    if and only if it appears on the trait implementation itself
    (since users can just go to the trait definition for anything not
    covered in the impl docs). This means we expect:
    
    * S1, S2, and S3 to all include top-level trait impl docs.
    * S1, S2, and S3 to exclude all trait definition docs.
    * S1 to show impl docs for `a_method`.
    * S2 to show impl docs for `a_method` and `b_method`.
    * S3 to show impl docs for `b_method`.
    
    These tests cover those cases.
    pierzchalski committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    d95ca28 View commit details
    Browse the repository at this point in the history
  3. Add flag for whether an item is default or not.

    We don't want to render default item docs but previously
    `doctraititem` naively delegated to the trait definition in those
    cases.
    
    Updated tests to also check that this doesn't strip default item
    docs from the trait definition.
    pierzchalski committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    ec5e0f8 View commit details
    Browse the repository at this point in the history
  4. alloc_system: Handle failure properly

    The Unix implementation was incorrectly handling failure for reallocation of
    over-aligned types by not checking for NULL.
    
    Closes rust-lang#32993
    alexcrichton committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    99c0547 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#32923 - jseyfried:fix_hygiene, r=nrc

    Fix macro hygiene bug
    
    This fixes rust-lang#32922 (EDIT: and fixes rust-lang#31856), macro hygiene bugs.
    It is a [breaking-change]. For example, the following would break:
    ```rust
    fn main() {
        let x = true;
        macro_rules! foo { () => {
            let x = 0;
            macro_rules! bar { () => {x} }
            let _: bool = bar!();
            //^ `bar!()` used to resolve the first `x` (a bool),
            //| but will now resolve to the second x (an i32).
        }}
        foo! {};
    }
    ```
    
    r? @nrc
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    6a0cfbc View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#32926 - caipre:rustbuild-verify-download, r…

    …=alexcrichton
    
    rustbuild: Verify sha256 of downloaded tarballs
    
    Here's a quick first pass at this.
    
    I don't use Python often enough to claim that this is totally Pythonic. I've left off some (almost certainly unnecessary) error handling regarding opening and processing files. The whole tarball is read into memory to calculate the hash, but the file isn't *so* large so that should be fine. I don't care for the output from `raise RuntimeError`, but that's how `run()` does it so I'm following precedent.
    
    Tested by manually changing the value of `expected`, and by modifying the tarball then forcing `rustc_out_of_date()`. Both cases tripped the error.
    
    Closes rust-lang#32902
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    70601b8 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#32929 - LeoTestard:featureck-comment, r=Gui…

    …llaumeGomez
    
    Update a comment to reflect changes in tidy checks.
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    7e36dc3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#32931 - deepak:gh-issue-32928-update-cargo-…

    …in-getting-started-doc, r=GuillaumeGomez
    
    Doc fix: Update Cargo.toml in book/getting-started
    
    The Cargo.toml mentioned in book/getting-started
    is missing the section called `[dependencies]`
    
    fixes rust-lang#32928
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    50932f5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#32935 - pierzchalski:restore_trait_impl_doc…

    …s, r=alexcrichton
    
    Restore trait impl docs
    
    Currently, documentation on methods in trait implementations doesn't get rendered. This changes that;  trait implementations have all documentation associated with impl items displayed (documentation from the trait definition is ignored).
    
    Fixes rust-lang#24838
    Fixes rust-lang#26871
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    fbbe85c View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#32945 - durka:rfc1494, r=pnkfelix

    implement RFC amendment 1494
    
    Adds `:block` to the follow set for `:ty` and `:path`. See rust-lang/rfcs#1494.
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    90c8d81 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#32946 - eddyb:issue-32783, r=dotdash

    trans: always register an item's symbol, even if duplicated.
    
    Fixes rust-lang#32783 which was introduced by not always registering item symbols in rust-lang#32742.
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    5bdbf8e View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#32964 - tshepang:comma, r=GuillaumeGomez

    doc: add missing comma
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    9873771 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#32970 - taralx:patch-2, r=alexcrichton

    Accommodate the case where dup lang items are entirely external.
    
    Fixes rust-lang#32961
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    00d4ac3 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#32973 - kindlychung:patch-1, r=steveklabnik

    remove "#" symbols to make the code compile
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    eba8055 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#32997 - alexcrichton:fix-alloc-system-how-d…

    …id-this-land, r=nagisa
    
    alloc_system: Handle failure properly
    
    The Unix implementation was incorrectly handling failure for reallocation of
    over-aligned types by not checking for NULL.
    
    Closes rust-lang#32993
    Manishearth committed Apr 15, 2016
    Configuration menu
    Copy the full SHA
    e563359 View commit details
    Browse the repository at this point in the history