Merge feature.color-4 into main #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still missing some planned deprecations and doubtlessly has bugs in the new features, but it's enough to provide a baseline to begin iterating on in smaller chunks. See #1805 See sass/sass#2831
I used this offline script to construct the color matrices, but it was never meant to be checked in.
Merge main into feature.color-4
Merge origin/main into feature.color-4
Merge main into feature.color-4
Merge origin/main into feature.color-4
This was referenced Sep 12, 2024
jathak
approved these changes
Sep 12, 2024
test/dart_api/value/color_test.dart
Outdated
| @@ -2,6 +2,7 @@ | |||
| // MIT-style license that can be found in the LICENSE file or at | |||
| // https://opensource.org/licenses/MIT. | |||
|
|
|||
| @Skip("TODO(nweiz): Update these for the new Color API") | |||
There was a problem hiding this comment.
Should this have a tracking bug?
There was a problem hiding this comment.
Oops! I've just updated these in this PR, PTAL
jathak
approved these changes
Sep 13, 2024
|
I think the CI is going weird here because GitHub can't tell the difference between the PR actions and the normal branch actions, and the branch actions aren't handling the link with the language repo properly. I'm just going to merge and clean up any failures after the fact. |
|
Actually, GitHub can differentiate them. But the dropdown showing the list has a max-width and truncates the names of the statuses when they are too long to fit, and the info to distinguish the status being set by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1805
See sass/sass#3930
See sass/sass-spec#2013
[skip sass-embedded]