-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename toXXX
methods
#1919
Conversation
@jpivarski I feel like we touched on this before but I don't recall the solution and can't find the discussion :/ If you're against this, close it, if in favour, merge! :) |
ecaa9cb
to
f838754
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember it, too. I didn't like your earlier suggestions that made the whole method names lowercase (they should reflect the names of the classes they instantiate), but I was in favor of the underscore after "to," which this PR applies.
You're right that this is our last chance to fix it because it's public API. In fact, it's public API that Uproot uses, so we'll also need to coordinate releases. It's not used by dask-awkward, awkward-pandas, or Vector, which would be harder to coordinate with.
- I'll make a PR on Uproot that uses the new
to_
names, but I will not merge it. You'll be the reviewer of that PR. - We'll make another pre-release of Awkward this week. (Probably more than one.)
- Then when Uproot breaks, I'll merge that Uproot PR to unbreak it.
- There should probably be another pre-release of Uproot, to give people something to test.
Codecov Report
Additional details and impacted files
|
I ran another test with |
… the new minimum version.
* refactor: adjust for name change in scikit-hep/awkward#1919. * If awkward>=2.0.0rc5 contains scikit-hep/awkward#1919, it will become the new minimum version.
This PR tackles a small naming inconsistency. Because these are public functions, we should decide now whether to merge this!
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-refactor-rename-to-xxx/ once Read the Docs has finished building 🔨