fix: __array__ = 'sorted_map' should only be allowed on RecordArrays, not lists. #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although I don't know why that Uproot test didn't fail for not having #1919. scikit-hep/uproot5#788 is waiting to fix that, but I would have thought it would trigger in that test. |
Codecov Report
Additional details and impacted files
|
agoose77
approved these changes
Dec 6, 2022
agoose77
deleted the
jpivarski/__array__-sorted_map-only-allowed-on-RecordArray-not-lists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops: #1939 constrains
__array__ = 'sorted_map'to be only allowed on list-types, when it is only allowed on record-types. There's no implementation of sorted map behaviors yet, but Uproot produces them in anticipation.This PR is necessary to fix Uproot. See the failure here (raw logs):
https://github.com/scikit-hep/uproot5/actions/runs/3625653080/jobs/6113923488
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/jpivarski-__array__-sorted_map-only-allowed-on-recordarray-not-lists/ once Read the Docs has finished building 🔨