Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust for name change in scikit-hep/awkward#1919. #788

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Nov 28, 2022

The tests in this PR will fail until the change in scikit-hep/awkward#1919 makes its way into a release, 2.0.0rc5 (probably). Once that happens, these tests will pass and all others will fail.

Follow the plan described in scikit-hep/awkward#1919 (review).

@jpivarski jpivarski changed the title refactor: adjust for name change in scikit-hep/awkward#1919. feat: adjust for name change in scikit-hep/awkward#1919. Nov 28, 2022
@agoose77 agoose77 closed this Dec 6, 2022
@agoose77 agoose77 reopened this Dec 6, 2022
@jpivarski jpivarski marked this pull request as ready for review December 6, 2022 22:07
@jpivarski
Copy link
Member Author

@agoose77 Now that the name change has propagated to an Awkward release, this Uproot PR should follow. (And then an Uproot RC release.)

@jpivarski
Copy link
Member Author

Okay, I'll merge it. Thanks!

@jpivarski jpivarski merged commit 803e80c into main Dec 6, 2022
@jpivarski jpivarski deleted the jpivarski/scikit-hep/awkward#1919 branch December 6, 2022 22:38
@jpivarski jpivarski removed the next-release Required for the next release label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants