Skip to content

Commit

Permalink
fix: Fix seeking timeouts (#6539)
Browse files Browse the repository at this point in the history
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
  • Loading branch information
joeyparrish authored May 6, 2024
1 parent d494068 commit fda3c8f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions lib/media/playhead.js
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,10 @@ shaka.media.MediaSourcePlayhead = class {
seekStart = seekEnd - this.minSeekRange_;
}

if (currentTime < seekStart || currentTime > seekEnd) {
// playhead is outside of the seekrange. Move playhead to catch up.
if (currentTime < seekStart) {
// The seek range has moved past the playhead. Move ahead to catch up.
const targetTime = this.reposition_(currentTime);
shaka.log.info('Jumping by ' + (targetTime - currentTime) +
shaka.log.info('Jumping forward ' + (targetTime - currentTime) +
' seconds to catch up with the seek range.');
this.mediaElement_.currentTime = targetTime;
}
Expand Down
2 changes: 1 addition & 1 deletion test/media/playhead_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ describe('Playhead', () => {

// It should allow a small buffer around the seek range.
seekCount = 0;
currentTime = 1030;
currentTime = 1030.062441;
jasmine.clock().tick(500);
currentTime = 1027.9233;
jasmine.clock().tick(500);
Expand Down

0 comments on commit fda3c8f

Please sign in to comment.