-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible to seek beyond live edge. Not corrected #5202
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
@Wayne-Morgan are you interested on send a PR for it? Thanks! |
avelad
added
flag: seeking PR
We are actively seeking PRs for this; we do not currently expect the core team will resolve this
priority: P2
Smaller impact or easy workaround
labels
Sep 27, 2023
Encountered the same issue. |
Please do! I'll assign the issue to you. |
@CeilingFANC Are you still interested in submitting the PR? Thanks! |
Yes. Just updated the test. How can I reopen the PR.. |
What PR? |
@CeilingFANC I reopened your PR. Thanks! |
avelad
added a commit
that referenced
this issue
Apr 12, 2024
Fixes #5202 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad
added a commit
that referenced
this issue
Apr 15, 2024
Fixes #5202 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad
added a commit
that referenced
this issue
Apr 15, 2024
Fixes #5202 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this issue
May 6, 2024
PR shaka-project#6304 caused seeking timeouts in Cast Application Framework, in v4.7.13, v4.8.0, and v4.8.1. Reverts "fix: Correct playhead when seek beyond seekRange (shaka-project#6304)" This reverts commit f91188e. Reopens shaka-project#5202
joeyparrish
added a commit
that referenced
this issue
May 6, 2024
joeyparrish
added a commit
that referenced
this issue
May 6, 2024
joeyparrish
added a commit
that referenced
this issue
May 7, 2024
joeyparrish
added a commit
that referenced
this issue
May 7, 2024
avelad
removed
the
flag: seeking PR
We are actively seeking PRs for this; we do not currently expect the core team will resolve this
label
Jul 9, 2024
avelad
added a commit
that referenced
this issue
Jul 10, 2024
Previously, we added a 1 second "cooldown" period between attempts to perform a corrective seek. This was for the benefit of old v1 Chromecasts, which found the process of seeking so slow that they would sometimes get stuck in an infinite loop trying to start a presentation. However, that cooldown period was causing issues in some situations during seeking, so this PR removes the restriction on everything but pre-Android Chromecast devices. Fixes #4393 Fixes #5202 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad
added a commit
that referenced
this issue
Jul 10, 2024
Previously, we added a 1 second "cooldown" period between attempts to perform a corrective seek. This was for the benefit of old v1 Chromecasts, which found the process of seeking so slow that they would sometimes get stuck in an infinite loop trying to start a presentation. However, that cooldown period was causing issues in some situations during seeking, so this PR removes the restriction on everything but pre-Android Chromecast devices. Fixes #4393 Fixes #5202 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3.5
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Custom app, but also reproduced in demo
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Various, but reproduced on Windows Chrome with the demo app
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
Reproduced with "Live Sim (2s segments)"
What configuration are you using? What is the output of
player.getConfiguration()
?Reproduced with default config
What did you do?
Seek beyond the seekable range, wait half a second, then do it again
What did you expect to happen?
The video to play from the live edge
What actually happened?
The player got stuck waiting.
I also tried seeking a smaller amount into the future (1 minute), and it recovered and started playing after a minute
The problem seems to be in
MediaSourcePlayhead.onSeeking_()
shaka-player/lib/media/playhead.js
Line 409 in a8e3c9a
The first seek out of range is corrected, but because the next happens within a second, the correction is simply discarded.
The text was updated successfully, but these errors were encountered: