Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct playhead when seek beyond seekRange #6304

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix: Correct playhead when seek beyond seekRange #6304

merged 5 commits into from
Apr 12, 2024

Conversation

CeilingFANC
Copy link
Contributor

@CeilingFANC CeilingFANC commented Feb 27, 2024 •
edited by avelad
Loading

Use recurring timer to correct playhead when time is beyond seekRange.
Fixes #5202

@google-cla Google CLA
Copy link

google-cla bot commented Feb 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@avelad
Copy link
Member

avelad commented Feb 27, 2024

@CeilingFANC please sign the CLA! Thanks!

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Feb 27, 2024
@avelad avelad added this to the v5.0 milestone Feb 27, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@joeyparrish
Copy link
Member

@CeilingFANC, this is failing tests on all platforms. You can run the tests yourself with python3 build/test.py.

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 6, 2024
joeyparrish
joeyparrish reviewed Mar 7, 2024
View reviewed changes
lib/media/playhead.js Outdated Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If the author would like to continue this PR, they can reopen it (preferred) or start a new one (if needed).

@shaka-bot shaka-bot closed this Mar 13, 2024
@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Mar 13, 2024
@avelad
Copy link
Member

avelad commented Apr 10, 2024

@CeilingFANC I reopened it

@avelad avelad reopened this Apr 10, 2024
@avelad
Copy link
Member

avelad commented Apr 10, 2024

@CeilingFANC Please, rebase!

@avelad avelad requested a review from theodab April 10, 2024 18:19
@avelad avelad merged commit a6d27a9 into shaka-project:main Apr 12, 2024
15 of 16 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 12, 2024
Merged
avelad added a commit that referenced this pull request Apr 15, 2024
@CeilingFANC @avelad
fix: Correct playhead when seek beyond seekRange (#6304)
09b154e 
Fixes #5202

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
@shaka-bot shaka-bot mentioned this pull request Apr 10, 2024
Merged
avelad added a commit that referenced this pull request Apr 15, 2024
@CeilingFANC @avelad
fix: Correct playhead when seek beyond seekRange (#6304)
f91188e 
Fixes #5202

---------

Co-authored-by: Álvaro Velad Galván <[email protected]>
@shaka-bot shaka-bot mentioned this pull request Apr 10, 2024
Merged
@joeyparrish
Copy link
Member

This PR has been identified as the cause of seeking-related bugs in the Cast Application Framework, affecting v4.7.13, v4.8.0, and v4.8.1. I will revert this PR and reopen the associated issue. The reverted PR will appear in v4.7.14 and v4.8.2.

joeyparrish added a commit to joeyparrish/shaka-player that referenced this pull request May 6, 2024
@joeyparrish
fix: Fix seeking timeouts
c4dfef3 
PR shaka-project#6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (shaka-project#6304)"

This reverts commit f91188e.

Reopens shaka-project#5202
@joeyparrish joeyparrish mentioned this pull request May 6, 2024
Merged
@joeyparrish
Copy link
Member

Reverted by #6539

joeyparrish added a commit that referenced this pull request May 6, 2024
@joeyparrish
fix: Fix seeking timeouts (#6539)
fda3c8f 
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
joeyparrish added a commit that referenced this pull request May 6, 2024
@joeyparrish
fix: Fix seeking timeouts (#6539)
b3e3eef 
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
joeyparrish added a commit that referenced this pull request May 7, 2024
@joeyparrish
fix: Fix seeking timeouts (#6539)
891ab06 
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
joeyparrish added a commit that referenced this pull request May 7, 2024
@joeyparrish
fix: Fix seeking timeouts (#6539)
f81908f 
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 11, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish left review comments

@avelad avelad avelad left review comments

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

Possible to seek beyond live edge. Not corrected
5 participants
@CeilingFANC @avelad @shaka-bot @joeyparrish @theodab