Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes for 3.4.4-beta2 preview #1112

Merged
merged 37 commits into from
Aug 17, 2024

Conversation

shiftkey
Copy link
Owner

@shiftkey shiftkey commented Aug 17, 2024

  • CI passes
  • diff makes sense
  • can package and run app locally

shiftkey and others added 30 commits August 16, 2024 21:25
Updated the "About GitHub Desktop" model to remove the button to check for updates (since it didn't do anything on Linux) and replace with a link to the linux releases page
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
There already exists a function that will convert a tilde path to an absolute path. It was originally used for this purpose, but the functionality was removed during a commit that changed which function was used to validate git repositories.

This reinstates that functionality and allows us to type a ~/ tilde path to get our home directories when typing in a path.
* drop old icon used in app window
* regenerate smaller icons from new 256px source
@shiftkey shiftkey marked this pull request as ready for review August 17, 2024 01:27
@shiftkey shiftkey merged commit b1a38e6 into linux-release-3.4.4-beta2 Aug 17, 2024
9 checks passed
@shiftkey shiftkey deleted the apply-changes-3.4.4-beta2 branch August 17, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants