Fix #596 and #598: error profiling throughput grid on aws and gcp #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnliu030
force-pushed
the
596-error-profiling-throughput-grid-for-skyplane-on-aws
branch
from
4ce066d
to
928fdac
Compare
parasj
reviewed
Oct 12, 2022
Dockerfile
Outdated
| @@ -5,6 +5,7 @@ FROM python:3.10-slim | |||
| RUN --mount=type=cache,target=/var/cache/apt apt update \ | |||
| && apt-get install --no-install-recommends -y curl ca-certificates stunnel4 \ | |||
| && apt-get clean \ | |||
| && apt-get -y install gcc mono-mcs \ | |||
There was a problem hiding this comment.
Why do you add mono-mcs and gcc?
…login_name to cached property
lynnliu030
deleted the
596-error-profiling-throughput-grid-for-skyplane-on-aws
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to fix #596 and #598 with added functionality to overwrite the default AMI to ubuntu for profiling. Also edit the firewall rule on GCP to allow iperf3 connections and use private IPs for within-GCP throughput profile
There're some minor errors with package installation and image & host platform mismatch when building from source with docker on Mac M1, include the fix here as well.